Opened 2 years ago

Closed 2 years ago

#27317 closed enhancement (fixed)

py3: partial care for matrix/

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 4ac9c1f (Commits, GitHub, GitLab) Commit: 4ac9c1fb5bbb9682ad555cda02b741ed21f466f0
Dependencies: Stopgaps:

Status badges

Description

inluding fixing one bad range

Change History (7)

comment:1 Changed 2 years ago by chapoton

  • Branch set to u/chapoton/27317
  • Commit set to e6d2fcc39dce80c9bd99dc41cae3979e955ca462
  • Status changed from new to needs_review

comment:2 Changed 2 years ago by dcoudert

I know it's only for py3 compatibility, but wouldn't it be better in this case to compute the maxrest_order) before ?

+            j = min(ind for ind in range(len(rest_order))
+                    if rest_order[ind] == max(rest_order))

Otherwise, looks good to me.

comment:3 Changed 2 years ago by git

  • Commit changed from e6d2fcc39dce80c9bd99dc41cae3979e955ca462 to 4ac9c1fb5bbb9682ad555cda02b741ed21f466f0

Branch pushed to git repo; I updated commit sha1. New commits:

4ac9c1ftrac 27317 more efficient code

comment:4 Changed 2 years ago by chapoton

Voilà, voilà. Avec quelques autres petites améliorations autour..

comment:5 Changed 2 years ago by dcoudert

LGTM.

comment:6 Changed 2 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

comment:7 Changed 2 years ago by vbraun

  • Branch changed from u/chapoton/27317 to 4ac9c1fb5bbb9682ad555cda02b741ed21f466f0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.