Opened 3 months ago

Closed 3 months ago

#27305 closed enhancement (fixed)

various fixes after lgtm suggestions

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: refactoring Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 3d50e79 (Commits) Commit: 3d50e7904b5b4f017e4e705fe669b24c604a15c4
Dependencies: Stopgaps:

Description


Change History (5)

comment:1 Changed 3 months ago by chapoton

  • Branch set to u/chapoton/27305
  • Commit set to 560cd2df39a5a67355b2bb72ba513c860f65cb7e
  • Status changed from new to needs_review

New commits:

560cd2dvarious small fixes (along some lgtm suggestions)

comment:2 Changed 3 months ago by git

  • Commit changed from 560cd2df39a5a67355b2bb72ba513c860f65cb7e to 3d50e7904b5b4f017e4e705fe669b24c604a15c4

Branch pushed to git repo; I updated commit sha1. New commits:

3d50e79trac 27305 fix pyflakes warnings

comment:3 Changed 3 months ago by chapoton

  • Cc tscrim added

green bot, please review

comment:4 Changed 3 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:5 Changed 3 months ago by vbraun

  • Branch changed from u/chapoton/27305 to 3d50e7904b5b4f017e4e705fe669b24c604a15c4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.