Opened 3 months ago

Closed 3 months ago

#27301 closed defect (fixed)

A few small py3 fixes in sage.misc

Reported by: jhpalmieri Owned by:
Priority: minor Milestone: sage-8.7
Component: python3 Keywords: python3
Cc: Merged in:
Authors: John Palmieri Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 1e7678e (Commits) Commit: 1e7678ea42bea24830b01c4beda52dc88a39bdcf
Dependencies: Stopgaps:

Description

Fix py3 doctest failures in 

function_mangling.pyx
misc.py
sage_input.py
sagedoc.py
sageinspect.py
trace.py

Change History (7)

comment:1 Changed 3 months ago by jhpalmieri

  • Branch set to u/jhpalmieri/misc-py3

comment:2 Changed 3 months ago by jhpalmieri

  • Commit set to e48dcf690fb439d1ca56d168afb5cd84da52d0ce
  • Status changed from new to needs_review

New commits:

​e48dcf6trac 27301: small sage.misc Python 3 fixes

comment:3 Changed 3 months ago by chapoton

  • Status changed from needs_review to needs_work

one easy failing doctest, see patchbot report

comment:4 Changed 3 months ago by git

  • Commit changed from e48dcf690fb439d1ca56d168afb5cd84da52d0ce to 1e7678ea42bea24830b01c4beda52dc88a39bdcf

Branch pushed to git repo; I updated commit sha1. New commits:

​1e7678etrac 27301: fix one long doctest

comment:5 Changed 3 months ago by jhpalmieri

  • Status changed from needs_work to needs_review

Sorry, I didn't run long tests before, so I didn't catch this one.

comment:6 Changed 3 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, well. Looks good

comment:7 Changed 3 months ago by vbraun

  • Branch changed from u/jhpalmieri/misc-py3 to 1e7678ea42bea24830b01c4beda52dc88a39bdcf
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.