Opened 2 years ago

Closed 2 years ago

#27296 closed defect (fixed)

comments in French

Reported by: gh-jfraymond Owned by:
Priority: minor Milestone: sage-8.7
Component: documentation Keywords:
Cc: Merged in:
Authors: Jean-Florent Raymond Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: 99065d2 (Commits, GitHub, GitLab) Commit: 99065d2ac9a7056ee32ac2acf0345c60a823bd41
Dependencies: Stopgaps:

Status badges

Description (last modified by gh-jfraymond)

Fixing:

  • independant -> independent
  • symetry -> symmetry
  • french comments in combinat/words/morphism.py and combinat/interval_posets.py

+ a few more.

Change History (10)

comment:1 Changed 2 years ago by gh-jfraymond

  • Branch set to u/gh-jfraymond/comments_in_french

comment:2 Changed 2 years ago by git

  • Commit set to c6204c981b8d0fe250e371502b1d96f111a41ef3

Branch pushed to git repo; I updated commit sha1. New commits:

c6204c9links to french wikipedia replaced with their english version

comment:3 Changed 2 years ago by git

  • Commit changed from c6204c981b8d0fe250e371502b1d96f111a41ef3 to c2c7ea68f1882253b1c42daabd8f40f16da5532e

Branch pushed to git repo; I updated commit sha1. New commits:

c2c7ea6a few more typos: 'symetries' and 'produit'

comment:4 Changed 2 years ago by gh-jfraymond

  • Authors set to Jean-Florent Raymond
  • Description modified (diff)
  • Status changed from new to needs_review

comment:5 Changed 2 years ago by chapoton

rather use Wiener-Araya_graph in wikipedia link to Wiener–Araya_graph to avoid the unicode dash symbol.

otherwise, good to go

comment:6 Changed 2 years ago by dcoudert

The french wikipedia page of the Sousselier graph contains currently much more information than the english one. Graphe_de_Sousselier vs. Sousselier_graph. I did not changed it when working on #25590 for that. May be we could have both links ?

comment:7 Changed 2 years ago by chapoton

  • Branch changed from u/gh-jfraymond/comments_in_french to public/ticket/27296
  • Commit changed from c2c7ea68f1882253b1c42daabd8f40f16da5532e to 2c16950406af773a6b092344410c5937f22d0cba

Here is a new branch where:

  • changes in giac interface are now made in #23313,
  • wikipedia links have been corrected as suggested.

Needs review now


New commits:

2c16950a few more typos: 'symetries' and 'produit'

comment:8 Changed 2 years ago by git

  • Commit changed from 2c16950406af773a6b092344410c5937f22d0cba to 99065d2ac9a7056ee32ac2acf0345c60a823bd41

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

99065d2fixing text in French

comment:9 Changed 2 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

LGTM.

comment:10 Changed 2 years ago by vbraun

  • Branch changed from public/ticket/27296 to 99065d2ac9a7056ee32ac2acf0345c60a823bd41
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.