Opened 3 years ago

Closed 3 years ago

Last modified 17 months ago

#27291 closed enhancement (fixed)

Frenchism (typos): "representative" should be used instead of "representant"

Reported by: falque Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords: typo
Cc: Merged in:
Authors: Prajjwal Jha Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: fe55aa0 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

In many places, "representant" is used instead of "representative".

Change History (30)

comment:1 Changed 3 years ago by falque

  • Component changed from PLEASE CHANGE to graph theory

comment:2 Changed 3 years ago by gh-JhaPrajjwal

NO branch is associated with this. How do I push my changes from the local branch?.

comment:3 Changed 3 years ago by chapoton

  • push your local branch to git.sagemath.org or trac.sagemath.org
  • fill the branch name in the ticket description here

comment:4 Changed 3 years ago by gh-JhaPrajjwal

  • Branch set to u/JhaPrajjwal/Corrected__representant_to_representative

comment:5 Changed 3 years ago by gh-JhaPrajjwal

  • Branch changed from u/JhaPrajjwal/Corrected__representant_to_representative to u/JhaPrajjwal/Corrected

comment:6 Changed 3 years ago by chapoton

your branch name should probably use your login name "gh-JhaPrajjwal?"

comment:7 Changed 3 years ago by chapoton

did you manage to push a branch ?

comment:8 Changed 3 years ago by gh-JhaPrajjwal

I need a trac account. I had requested for it about 2 days ago.

comment:9 Changed 3 years ago by chapoton

No, you do not need an account, I do not think so.

http://doc.sagemath.org/html/en/developer/trac.html#obtaining-an-account

If you know how to use "git" (and not our optional custom plugin called "git trac"), then you can just push with your github login.

Something like

git push trac HEAD:u/gh-JhaPrajjwal/mybranchname

should just work.

comment:10 Changed 3 years ago by gh-JhaPrajjwal

In that case ,I recieve this error:

git@…: Permission denied (publickey). fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

comment:11 Changed 3 years ago by gh-JhaPrajjwal

  • Branch u/JhaPrajjwal/Corrected deleted

comment:12 Changed 3 years ago by chapoton

you need to set up your public key inside trac, as explained below in the same page:

http://doc.sagemath.org/html/en/developer/trac.html

comment:13 Changed 3 years ago by gh-JhaPrajjwal

  • Branch set to u/gh-JhaPrajjwal/sage_branch
  • Commit set to 76683a7f1c9ca1476b1c69e26e6fe049ba207d15

New commits:

76683a7Changed "representant" to "Representative"

comment:14 Changed 3 years ago by gh-JhaPrajjwal

  • Status changed from new to needs_review

comment:15 Changed 3 years ago by gh-JhaPrajjwal

Can you check now? And Thankyou for your help chapoton.

comment:16 follow-up: Changed 3 years ago by chapoton

Good. Now there is a branch to look at.

But your branch contains a bad file: octave-workspace

comment:17 follow-up: Changed 3 years ago by chapoton

a suggestion (for your next ticket): give your branches some name that either contains the ticket number or describes what the branch does

comment:18 in reply to: ↑ 16 ; follow-up: Changed 3 years ago by gh-JhaPrajjwal

Replying to chapoton:

Good. Now there is a branch to look at.

But your branch contains a bad file: octave-workspace

What should I do about it?

comment:19 in reply to: ↑ 17 Changed 3 years ago by gh-JhaPrajjwal

Replying to chapoton:

a suggestion (for your next ticket): give your branches some name that either contains the ticket number or describes what the branch does

Okay!

comment:20 in reply to: ↑ 18 Changed 3 years ago by chapoton

Replying to gh-JhaPrajjwal:

Replying to chapoton:

Good. Now there is a branch to look at.

But your branch contains a bad file: octave-workspace

What should I do about it?

Well, make a branch where this file is not added, and push it here...

comment:21 Changed 3 years ago by gh-JhaPrajjwal

  • Branch changed from u/gh-JhaPrajjwal/sage_branch to u/gh-JhaPrajjwal/27291

comment:22 Changed 3 years ago by chapoton

still the same problem. You can click on the Branch: field in the ticket description to see the bad file that you are adding.

I suggest "git rm octave-workspace", then "commit", then "rebase -i develop" to squash the commits, then "push -f"

comment:23 Changed 3 years ago by chapoton

Are you Justine Falque or Jha Prajjwal ? Please fix the Author fullname: field in the ticket description, if necessary.

comment:24 Changed 3 years ago by gh-JhaPrajjwal

  • Authors changed from Justine Falque to Jha Prajjwal

comment:25 Changed 3 years ago by git

  • Commit changed from 76683a7f1c9ca1476b1c69e26e6fe049ba207d15 to fe55aa0723eda955d38f4b3a78da377c65716b36

Branch pushed to git repo; I updated commit sha1. New commits:

fe55aa0removed octave-workspace

comment:26 Changed 3 years ago by gh-JhaPrajjwal

Is it okay now?

comment:27 Changed 3 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, thanks

comment:28 Changed 3 years ago by vbraun

  • Branch changed from u/gh-JhaPrajjwal/27291 to fe55aa0723eda955d38f4b3a78da377c65716b36
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:29 Changed 2 years ago by slelievre

  • Commit fe55aa0723eda955d38f4b3a78da377c65716b36 deleted

At #18855 you put "Prajjwal Jha" as author name, and here you put "Jha Prajjwal". Would you mind changing one or the other to make it consistent?

comment:30 Changed 17 months ago by mkoeppe

  • Authors changed from Jha Prajjwal to Prajjwal Jha
Note: See TracTickets for help on using tickets.