Opened 4 years ago
Last modified 3 years ago
#27271 closed enhancement
spkg-configure.m4 for ecm — at Version 11
Reported by: | dimpase | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.9 |
Component: | build | Keywords: | spkg-configure |
Cc: | embray, fbissey | Merged in: | |
Authors: | Dima Pasechnik | Reviewers: | |
Report Upstream: | N/A | Work issues: | |
Branch: | u/dimpase/packages/ecmconfig (Commits, GitHub, GitLab) | Commit: | cb3a637b22f7cffcc9a9e7a645499f0861edec54 |
Dependencies: | Stopgaps: |
Description (last modified by )
it needs gmp, and is not a dependency of anything (besides sagelib)
To get this package on the system:
- Fedora: gmp-ecm-devel
- Gentoo: gmp-ecm - (but the version is too old in the main tree. Decent one in the sage-on-gentoo overlay)
- FreeBSD: gmp-ecm
Change History (11)
comment:1 Changed 3 years ago by
- Milestone changed from sage-8.7 to sage-8.8
comment:2 Changed 3 years ago by
- Branch set to u/dimpase/packages/ecmconfig
- Commit set to 7d1f15e76c1b01da96fa00a20cdfab05623a1937
- Status changed from new to needs_review
checking the version by grepping the header, duh...
Last 10 new commits:
b80bf72 | Reworked this a bit more
|
0ca3f56 | fix typo
|
06798ca | added a bit more explanation
|
b592d77 | correct logic for SAGE_GMP_PREFIX etc
|
5057680 | add the AX_ABSOLUTE_HEADER macro
|
101537b | iml in particular is very picky about being given an absolute path to the
|
862ca6a | Merge remote-tracking branch 'trac/develop' into HEAD
|
03dc987 | Merged trac #27215 in
|
98c67d3 | Merge remote-tracking branch 'trac/public/packages/gmp_m4' into ecm-config
|
7d1f15e | spkg-configure for ecm
|
comment:3 follow-up: ↓ 4 Changed 3 years ago by
Does this really depend on #27212? I ask just because it's not clear to me exactly how, and this might be useful on its own as well.
comment:4 in reply to: ↑ 3 ; follow-up: ↓ 7 Changed 3 years ago by
Replying to embray:
Does this really depend on #27212? I ask just because it's not clear to me exactly how, and this might be useful on its own as well.
gmp/mpir is a dependency of ecm! (and so not using system's gmp/mpir and using the system's gmp/mpir for ecm would lead to a lot of linking/loading "fun" with sagelib)
comment:5 Changed 3 years ago by
As for the contents of the ecm/spkg-configure.m4
itself, it looks fine to me at first glance, an I trust you've tested it.
A slightly more "sophisticated" approach might be build a test program which prints the value of the version, but in this case it's simple enough that just grepping for it should be good enough.
comment:6 Changed 3 years ago by
I am going to submit an upstream patch to get a pkg-config configuration for ecm (more or less the same INRIA upstream accepted such patch for gf2x, so this will make this much easier, once in).
comment:7 in reply to: ↑ 4 Changed 3 years ago by
Replying to dimpase:
Replying to embray:
Does this really depend on #27212? I ask just because it's not clear to me exactly how, and this might be useful on its own as well.
gmp/mpir is a dependency of ecm! (and so not using system's gmp/mpir and using the system's gmp/mpir for ecm would lead to a lot of linking/loading "fun" with sagelib)
I see. In that case (and we still need a generic way to do this but I think it's tricky), the ecm/spkg-configure.m4
should do
AC_REQUIRE([SAGE_SPKG_CONFIGURE_GMP])
and then refuse to use the system package if sage_spkg_install_mpir = yes
or sage_spkg_install_gmp = yes
.
comment:8 Changed 3 years ago by
OK, so the latter applies to other tickets that have #27212 as a dependence.
comment:9 Changed 3 years ago by
- Commit changed from 7d1f15e76c1b01da96fa00a20cdfab05623a1937 to cb3a637b22f7cffcc9a9e7a645499f0861edec54
comment:10 Changed 3 years ago by
- Cc fbissey added
- Dependencies #27212 deleted
- Description modified (diff)
rebased over 8.8.beta5 and added the missing test. Can be reviewed now.
comment:11 Changed 3 years ago by
- Description modified (diff)
Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)