Opened 3 years ago
Closed 3 years ago
#27264 closed enhancement (duplicate)
spkgconfigure.m4 for flint
Reported by:  dimpase  Owned by:  

Priority:  major  Milestone:  sageduplicate/invalid/wontfix 
Component:  build  Keywords:  
Cc:  embray  Merged in:  
Authors:  Dima Pasechnik  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  u/dimpase/packages/flintconfig (Commits, GitHub, GitLab)  Commit:  8fc4fb6e6229b920f1a8cf76cf780a98ef7e3389 
Dependencies:  Stopgaps: 
Description
Flint on Sage is linked with NTL, and this can be checked by testing for presence of
fmpz_poly_get_ZZX
there. So, this:
SAGE_SPKG_CONFIGURE([flint], [ AC_CHECK_HEADER(flint/flint.h, [], [sage_spkg_install_flint=yes]) dnl fmpz_mat_is_hadamard appears in Flint 2.5.0 AC_SEARCH_LIBS([fmpz_mat_is_hadamard], [flint], [], [sage_spkg_install_flint=yes]) AC_SEARCH_LIBS([fmpz_poly_get_ZZX], [flint], [break], [sage_spkg_install_flint=yes]) ])
Change History (18)
comment:1 Changed 3 years ago by
comment:3 Changed 3 years ago by
 Branch set to u/dimpase/packages/flintconfig
 Commit set to 82772d7ba1e8a13311ba7b09ae50e36a2fb4356a
 Dependencies changed from #27265 to #27265, #27212
Last 10 new commits:
af9ab90  deal with withntl, proper version check

5e1a30b  spkgconfigure for mpfr, adjustments for its dependees

18fbf7b  add SAGE_CONFIGURE_MPFR, fix sageenvconfig.in

50aebab  implement withmpfr=system/install

0fc433f  update for Sage 8.7.rc0, a typo fix

38427e1  spkgconfigure for mpc, adjustments for its dependees

ec32471  Merge branch 'u/dimpase/packages/mpcconfig' of trac.sagemath.org:sage into mpf

91f423f  rebase, deal with withmpc

33edfa8  Merge branch 'mpf' into flintconf  no spkgconfigure yet

82772d7  spkgconfigure for flint

comment:4 Changed 3 years ago by
 Status changed from new to needs_review
comment:5 Changed 3 years ago by
Should we still look at NTL first, or maybe try testing with both this ticket and #27265 merged together?
comment:6 Changed 3 years ago by
Naturally, I am testing them all together... (this branch has them all).
Actually, there is a lot of common boilerplate in spkgconfigure.m4's for mpfr, mpc, ntl, and flint. But OK, perhaps this simplification can waitdepending upon how many more spkgs need with...=
support.
comment:7 Changed 3 years ago by
I agree, I think that for now it will be simpler and easier to understand if we are somewhat repetitive. If, once we've made more progress, a clear pattern emerges then I can certainly collapse the repetitive bits into a macro.
comment:8 Changed 3 years ago by
This needs an extra test that flint was not built with withgc=...
option, which results in a memory layout different from what Sage interface expects, and leads to crashes, e.g. in src/sage/libs/flint/fmpz_poly.pyx
.
This option is on on some systems by default, e.g. on Gentoo...
comment:9 Changed 3 years ago by
 Commit changed from 82772d7ba1e8a13311ba7b09ae50e36a2fb4356a to c1ac4f285130c058e97ca199b5b95f28c17ac52d
comment:10 Changed 3 years ago by
 Milestone changed from sage8.7 to sage8.8
Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)
comment:11 Changed 3 years ago by
 Commit changed from c1ac4f285130c058e97ca199b5b95f28c17ac52d to 0e0947d8902f3f4467a7e4686d2ba691cb7fdbd7
Branch pushed to git repo; I updated commit sha1. New commits:
0e0947d  typo in parameter

comment:12 Changed 3 years ago by
 Commit changed from 0e0947d8902f3f4467a7e4686d2ba691cb7fdbd7 to 88209e0d5519bff2458088760509ee56e798519c
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
1353705  another missing then

58c9acd  spkgconfigure for mpfr, adjustments for its dependees

ef60157  add SAGE_CONFIGURE_MPFR, fix sageenvconfig.in

1357bef  implement withmpfr=system/install

e7d04e7  spkgconfigure for mpc, adjustments for its dependees

fb3aec7  rebase, deal with withmpc

30b85f7  spkgconfigure for flint

e17167e  testi for GC enabled

d7f3747  proper nesting of tests

88209e0  typo in parameter

comment:13 Changed 3 years ago by
 Commit changed from 88209e0d5519bff2458088760509ee56e798519c to a867838cf39019f4769133d9b66d4dc5540fe3a3
Branch pushed to git repo; I updated commit sha1. New commits:
a867838  typo

comment:14 Changed 3 years ago by
 Commit changed from a867838cf39019f4769133d9b66d4dc5540fe3a3 to 8fc4fb6e6229b920f1a8cf76cf780a98ef7e3389
Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:
ef5c200  add SAGE_CONFIGURE_MPFR, fix sageenvconfig.in

9aab721  implement withmpfr=system/install

0392e76  rebase, deal with withmpc

73ce2a9  spkgconfigure for flint

37fa1a1  testi for GC enabled

4f6434c  proper nesting of tests

a672706  typo in parameter

013dfbe  typo

e698ffc  corrected rebase

8fc4fb6  add dependency checks, remove unneeded `with` handling

comment:15 Changed 3 years ago by
 Dependencies changed from #27265, #27212 to #27822
rebased over #27822 branch, added deps checks, etc
comment:16 Changed 3 years ago by
should this be bundled with arb?
comment:17 Changed 3 years ago by
 Dependencies #27822 deleted
 Milestone changed from sage8.8 to sageduplicate/invalid/wontfix
 Status changed from needs_review to positive_review
to be merged as a part of #27270
comment:18 Changed 3 years ago by
 Resolution set to duplicate
 Status changed from positive_review to closed
Do you want to go ahead and add a branch? Obviously, it seems fine to me at first glance.