Opened 2 years ago

Closed 21 months ago

#27264 closed enhancement (duplicate)

spkg-configure.m4 for flint

Reported by: dimpase Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: build Keywords:
Cc: embray Merged in:
Authors: Dima Pasechnik Reviewers:
Report Upstream: N/A Work issues:
Branch: u/dimpase/packages/flintconfig (Commits, GitHub, GitLab) Commit: 8fc4fb6e6229b920f1a8cf76cf780a98ef7e3389
Dependencies: Stopgaps:

Status badges

Description

Flint on Sage is linked with NTL, and this can be checked by testing for presence of fmpz_poly_get_ZZX there. So, this:

SAGE_SPKG_CONFIGURE([flint], [
    AC_CHECK_HEADER(flint/flint.h, [], [sage_spkg_install_flint=yes])
dnl fmpz_mat_is_hadamard appears in Flint 2.5.0
    AC_SEARCH_LIBS([fmpz_mat_is_hadamard], [flint], [], [sage_spkg_install_flint=yes])
    AC_SEARCH_LIBS([fmpz_poly_get_ZZX], [flint], [break], [sage_spkg_install_flint=yes])
])

Change History (18)

comment:1 Changed 2 years ago by embray

Do you want to go ahead and add a branch? Obviously, it seems fine to me at first glance.

comment:2 Changed 2 years ago by dimpase

  • Dependencies set to #27265

Yes, but need to do #27265 (NTL) first

comment:3 Changed 2 years ago by dimpase

  • Branch set to u/dimpase/packages/flintconfig
  • Commit set to 82772d7ba1e8a13311ba7b09ae50e36a2fb4356a
  • Dependencies changed from #27265 to #27265, #27212

Last 10 new commits:

af9ab90deal with --with-ntl, proper version check
5e1a30bspkg-configure for mpfr, adjustments for its dependees
18fbf7badd SAGE_CONFIGURE_MPFR, fix sage-env-config.in
50aebabimplement --with-mpfr=system/install
0fc433fupdate for Sage 8.7.rc0, a typo fix
38427e1spkg-configure for mpc, adjustments for its dependees
ec32471Merge branch 'u/dimpase/packages/mpc-config' of trac.sagemath.org:sage into mpf
91f423frebase, deal with --with-mpc
33edfa8Merge branch 'mpf' into flintconf - no spkg-configure yet
82772d7spkg-configure for flint

comment:4 Changed 2 years ago by dimpase

  • Status changed from new to needs_review

comment:5 Changed 2 years ago by embray

Should we still look at NTL first, or maybe try testing with both this ticket and #27265 merged together?

comment:6 Changed 2 years ago by dimpase

Naturally, I am testing them all together... (this branch has them all).

Actually, there is a lot of common boilerplate in spkg-configure.m4's for mpfr, mpc, ntl, and flint. But OK, perhaps this simplification can wait---depending upon how many more spkgs need --with-...= support.

comment:7 Changed 2 years ago by embray

I agree, I think that for now it will be simpler and easier to understand if we are somewhat repetitive. If, once we've made more progress, a clear pattern emerges then I can certainly collapse the repetitive bits into a macro.

comment:8 Changed 2 years ago by dimpase

This needs an extra test that flint was not built with --with-gc=... option, which results in a memory layout different from what Sage interface expects, and leads to crashes, e.g. in src/sage/libs/flint/fmpz_poly.pyx.

This option is on on some systems by default, e.g. on Gentoo...

comment:9 Changed 2 years ago by git

  • Commit changed from 82772d7ba1e8a13311ba7b09ae50e36a2fb4356a to c1ac4f285130c058e97ca199b5b95f28c17ac52d

Branch pushed to git repo; I updated commit sha1. New commits:

24f17d5testi for GC enabled
c1ac4f2proper nesting of tests

comment:10 Changed 2 years ago by embray

  • Milestone changed from sage-8.7 to sage-8.8

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

comment:11 Changed 2 years ago by git

  • Commit changed from c1ac4f285130c058e97ca199b5b95f28c17ac52d to 0e0947d8902f3f4467a7e4686d2ba691cb7fdbd7

Branch pushed to git repo; I updated commit sha1. New commits:

0e0947dtypo in parameter

comment:12 Changed 2 years ago by git

  • Commit changed from 0e0947d8902f3f4467a7e4686d2ba691cb7fdbd7 to 88209e0d5519bff2458088760509ee56e798519c

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

1353705another missing then
58c9acdspkg-configure for mpfr, adjustments for its dependees
ef60157add SAGE_CONFIGURE_MPFR, fix sage-env-config.in
1357befimplement --with-mpfr=system/install
e7d04e7spkg-configure for mpc, adjustments for its dependees
fb3aec7rebase, deal with --with-mpc
30b85f7spkg-configure for flint
e17167etesti for GC enabled
d7f3747proper nesting of tests
88209e0typo in parameter

comment:13 Changed 2 years ago by git

  • Commit changed from 88209e0d5519bff2458088760509ee56e798519c to a867838cf39019f4769133d9b66d4dc5540fe3a3

Branch pushed to git repo; I updated commit sha1. New commits:

a867838typo

comment:14 Changed 23 months ago by git

  • Commit changed from a867838cf39019f4769133d9b66d4dc5540fe3a3 to 8fc4fb6e6229b920f1a8cf76cf780a98ef7e3389

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

ef5c200add SAGE_CONFIGURE_MPFR, fix sage-env-config.in
9aab721implement --with-mpfr=system/install
0392e76rebase, deal with --with-mpc
73ce2a9spkg-configure for flint
37fa1a1testi for GC enabled
4f6434cproper nesting of tests
a672706typo in parameter
013dfbetypo
e698ffccorrected rebase
8fc4fb6add dependency checks, remove unneeded `-with` handling

comment:15 Changed 23 months ago by dimpase

  • Dependencies changed from #27265, #27212 to #27822

rebased over #27822 branch, added deps checks, etc

comment:16 Changed 23 months ago by dimpase

should this be bundled with arb?

comment:17 Changed 23 months ago by dimpase

  • Dependencies #27822 deleted
  • Milestone changed from sage-8.8 to sage-duplicate/invalid/wontfix
  • Status changed from needs_review to positive_review

to be merged as a part of #27270

comment:18 Changed 21 months ago by chapoton

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.