Opened 4 years ago

Closed 4 years ago

#27262 closed defect (fixed)

remove "Replacing library search directory in linker " in src/setup.py

Reported by: Dima Pasechnik Owned by:
Priority: major Milestone: sage-8.8
Component: build Keywords:
Cc: Erik Bray, Jeroen Demeyer, François Bissey Merged in:
Authors: Dima Pasechnik Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 0c4fc77 (Commits, GitHub, GitLab) Commit: 0c4fc77fb0e00ea0d185a2ac77f7098a4580791b
Dependencies: Stopgaps:

Status badges

Description

This hack prevents passing e.g. -L/usr/local/lib via LDFLAGS, so you cannot link sagelib with anything from there. So the proposal is to remove from there the whole

-        if True or sys.platform[:6]=="darwin":
-
-            sage_libdir = os.path.realpath(SAGE_LOCAL+"/lib")
-            ldso_cmd = self.compiler.linker_so # a list of strings, like argv
-
-            for i in range(1, len(ldso_cmd)):
-
-                if ldso_cmd[i][:2] == "-L":
-                    libdir = os.path.realpath(ldso_cmd[i][2:])
-                    self.debug_print(
-                      "Library dir found in dynamic linker command: " +
-                      "\"%s\"" % libdir)
-                    if libdir != sage_libdir:
-                        self.compiler.warn(
-                          "Replacing library search directory in linker " +
-                          "command:\n  \"%s\" -> \"%s\"\n" % (libdir,
-                                                              sage_libdir))
-                        ldso_cmd[i] = "-L"+sage_libdir
-

Change History (5)

comment:1 Changed 4 years ago by Erik Bray

Milestone: sage-8.7sage-8.8

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

comment:2 Changed 4 years ago by Dima Pasechnik

Branch: u/dimpase/build/dontmodifypath
Commit: 0c4fc77fb0e00ea0d185a2ac77f7098a4580791b
Status: newneeds_review

New commits:

0c4fc77remove obsolete path-modifying hack

comment:3 Changed 4 years ago by Dima Pasechnik

Authors: Dima Pasechnik
Cc: François Bissey added

comment:4 Changed 4 years ago by Jeroen Demeyer

Reviewers: Jeroen Demeyer
Status: needs_reviewpositive_review

comment:5 Changed 4 years ago by Volker Braun

Branch: u/dimpase/build/dontmodifypath0c4fc77fb0e00ea0d185a2ac77f7098a4580791b
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.