Opened 2 years ago

Closed 22 months ago

#27259 closed enhancement (duplicate)

spkg-configure.m4 for mpc

Reported by: dimpase Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: build: configure Keywords: spkg-configure mpc
Cc: embray Merged in:
Authors: Dima Pasechnik, Erik Bray Reviewers: Erik Bray, Dima Pasechnik
Report Upstream: N/A Work issues:
Branch: d15ead5 (Commits, GitHub, GitLab) Commit:
Dependencies: #27212, #27258 Stopgaps:

Status badges

Description (last modified by dimpase)

mpc depends on GMP/MPIR and MPFR. I am trying something like this:

SAGE_SPKG_CONFIGURE([mpc], [
    AC_CHECK_HEADER(mpc.h, [], [sage_spkg_install_mpc=yes])
dnl mpc_cmp_abs appeared in MPC 1.1.0
    AC_SEARCH_LIBS([mpc_cmp_abs], [mpc], [break], [sage_spkg_install_mpc=yes])
])

to be merged as a part of #27822

Change History (25)

comment:1 Changed 2 years ago by dimpase

mpfrcx's spkg-install hardcodes the location of mpc to SAGE_LOCAL. So this will need to be fixed.

comment:2 Changed 2 years ago by embray

That should be no problem (in theory). We'll treat the prefix for mpc similarly to how we've done with GMP.

comment:3 Changed 2 years ago by dimpase

  • Branch set to u/dimpase/packages/mpc-config
  • Commit set to db992bea51961ac8fb1ae8d9967f90f3af7a4c50

Last 10 new commits:

b070088Move all the --with-mp logic into the spkg-configure.m4 for MPIR so that it
3b6eebdReplace various --with-gmp=$SAGE_LOCAL flags in spkg-installs with a
b80bf72Reworked this a bit more
0ca3f56fix typo
06798caadded a bit more explanation
b592d77correct logic for SAGE_GMP_PREFIX etc
5057680add the AX_ABSOLUTE_HEADER macro
101537biml in particular is very picky about being given an absolute path to the
5e1a30bspkg-configure for mpfr, adjustments for its dependees
db992bespkg-configure for mpc, adjustments for its dependees

comment:4 Changed 2 years ago by git

  • Commit changed from db992bea51961ac8fb1ae8d9967f90f3af7a4c50 to 38427e143231467adce659ba5673b1aae2fd78c3

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

18fbf7badd SAGE_CONFIGURE_MPFR, fix sage-env-config.in
50aebabimplement --with-mpfr=system/install
38427e1spkg-configure for mpc, adjustments for its dependees

comment:5 Changed 2 years ago by git

  • Commit changed from 38427e143231467adce659ba5673b1aae2fd78c3 to 91f423fab339a3279897149b323d26f20833b843

Branch pushed to git repo; I updated commit sha1. New commits:

862ca6aMerge remote-tracking branch 'trac/develop' into HEAD
03dc987Merged trac #27215 in
c9873aeMerge remote-tracking branch 'trac/develop' into mpf
0fc433fupdate for Sage 8.7.rc0, a typo fix
ec32471Merge branch 'u/dimpase/packages/mpc-config' of trac.sagemath.org:sage into mpf
91f423frebase, deal with --with-mpc

comment:6 Changed 2 years ago by dimpase

  • Status changed from new to needs_review

New commits:

862ca6aMerge remote-tracking branch 'trac/develop' into HEAD
03dc987Merged trac #27215 in
c9873aeMerge remote-tracking branch 'trac/develop' into mpf
0fc433fupdate for Sage 8.7.rc0, a typo fix
ec32471Merge branch 'u/dimpase/packages/mpc-config' of trac.sagemath.org:sage into mpf
91f423frebase, deal with --with-mpc

comment:7 Changed 2 years ago by embray

  • Milestone changed from sage-8.7 to sage-8.8

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

comment:8 Changed 2 years ago by git

  • Commit changed from 91f423fab339a3279897149b323d26f20833b843 to f41aab4c2ceea2ae1e3cf30e5f6749b7d7916171

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0b72a68spkg-configure for mpfr, adjustments for its dependees
d690c9fadd SAGE_CONFIGURE_MPFR, fix sage-env-config.in
a833f93implement --with-mpfr=system/install
62feae3build mpir if gmp/mpir is built
df8e63dbumped up configure
bfac833spkg-configure for mpc, adjustments for its dependees
f41aab4rebase, deal with --with-mpc

comment:9 Changed 2 years ago by embray

  • Branch changed from u/dimpase/packages/mpc-config to public/packages/mpc-config
  • Commit changed from f41aab4c2ceea2ae1e3cf30e5f6749b7d7916171 to 953ba0297d9423fabef4d225037c3c9c1032c633

Rebased on latest #27258.

Confirmed that Sage built successfully on Ubuntu 18.04 with system gmp+mpfr+mpc among other packages. Running the tests now but they all passed in #27258, so I would be surprised if that changed here.


New commits:

d9bbdd4Add support for unconditional pre- and post-check actions in spkg-configure.m4
a360518Refactor the mpir/spkg-configure.m4 (and to a lesser extent the one for gmp) to use the new pre and post arguments to SAGE_SPKG_CONFIGURE
d5986afspkg-configure for mpfr, adjustments for its dependees
1948e33Add one missing SAGE_CONFIGURE_MPFR, for building gcc
16b907aspkg-configure for mpc, adjustments for its dependees
0c906f1rebase, deal with --with-mpc
5372ee0Clean up spkg-configure.m4 for mpc to follow the current model for mpc
428dfabUse SAGE_CONFIGURE_MPC for building gcc
953ba02Add missing AC_MSG_RESULT

comment:10 Changed 2 years ago by embray

Tests pass, so, LGTM. Would you like to test more on other systems or are you already generally satisfied with how this is?

comment:11 Changed 2 years ago by dimpase

I'll run tests on OSX and if all is good, set it and the mpfr tickets to positive reviews. Thanks!

comment:12 Changed 2 years ago by embray

And then we'll add a separate ticket just for a new confball?

comment:13 Changed 2 years ago by embray

  • Component changed from build to build: configure
  • Keywords mpc added

comment:14 Changed 2 years ago by dimpase

how about adding config tarball here?

or perhaps we can proceed rebasing nil/flint/arb over this one (we should do this one way or another) and add a config tarball on arb's ticket?

Last edited 2 years ago by dimpase (previous) (diff)

comment:15 Changed 2 years ago by dimpase

  • Authors changed from Dima Pasechnik to Dima Pasechnik, Erik Bray
  • Reviewers set to Erik Bray, Dima Pasechnik
  • Status changed from needs_review to positive_review

all clear

comment:16 Changed 2 years ago by git

  • Commit changed from 953ba0297d9423fabef4d225037c3c9c1032c633 to b63bc91bfcf24385b12a9f6910e68d8298b5afb2
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

ae3547espkg-configure for mpfr, adjustments for its dependees
1a2ceb0Add one missing SAGE_CONFIGURE_MPFR, for building gcc
b63bc91Trac #27259: spkg-configure for mpc, adjustments for its dependents

comment:17 Changed 2 years ago by embray

  • Status changed from needs_review to positive_review

Rebased and squashed.

comment:18 Changed 2 years ago by git

  • Commit changed from b63bc91bfcf24385b12a9f6910e68d8298b5afb2 to d15ead5ddb7403adf6511781f7fb295bcad7bd7b
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

d5e5e3dspkg-configure for mpfr, adjustments for its dependees
0329fd9Add one missing SAGE_CONFIGURE_MPFR, for building gcc
d15ead5Trac #27259: spkg-configure for mpc, adjustments for its dependents

comment:19 Changed 2 years ago by embray

  • Status changed from needs_review to positive_review

Rebased again, but specifically over the branch for #27258.

comment:20 Changed 2 years ago by embray

This ticket should probably not be merged by itself. Instead please merge #27822 which incorporates this one.

comment:21 Changed 2 years ago by vbraun

  • Branch changed from public/packages/mpc-config to d15ead5ddb7403adf6511781f7fb295bcad7bd7b
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:22 Changed 23 months ago by vbraun

  • Commit d15ead5ddb7403adf6511781f7fb295bcad7bd7b deleted
  • Resolution fixed deleted
  • Status changed from closed to new

comment:23 Changed 23 months ago by dimpase

  • Description modified (diff)
  • Milestone changed from sage-8.8 to sage-duplicate/invalid/wontfix
  • Status changed from new to needs_review

comment:24 Changed 23 months ago by dimpase

  • Status changed from needs_review to positive_review

comment:25 Changed 22 months ago by chapoton

  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.