Opened 3 years ago

Closed 3 years ago

#27251 closed enhancement (fixed)

fpylll: add patch for Cython 3.0

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.7
Component: packages: standard Keywords:
Cc: malb Merged in:
Authors: Jeroen Demeyer Reviewers: Martin Albrecht
Report Upstream: Fixed upstream, but not in a stable release. Work issues:
Branch: 5eee850 (Commits, GitHub, GitLab) Commit: 5eee85087e4205686de824ff40da5d6d5beb6051
Dependencies: Stopgaps:

Status badges

Description

Add this patch to fpylll to make it compatible with Cython master. The default value for language_level has changed, so the language_level is best specified explicitly.

This makes absolutely no difference with Cython 0.29.x, so it doesn't affect distributions.

The patch just makes it possible to compile Sage with Cython master (something that I regularly do when contributing to Cython).

Change History (9)

comment:1 Changed 3 years ago by jdemeyer

  • Branch set to u/jdemeyer/fpylll__add_patch_for_cython_3_0

comment:2 Changed 3 years ago by jdemeyer

  • Commit set to de93a451c5b233a174131243428232a0852e3a81
  • Status changed from new to needs_review

New commits:

de93a45fpylll: add patch for Cython 3

comment:3 Changed 3 years ago by git

  • Commit changed from de93a451c5b233a174131243428232a0852e3a81 to 5eee85087e4205686de824ff40da5d6d5beb6051

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5eee850fpylll: add patch for Cython 3

comment:4 Changed 3 years ago by jdemeyer

  • Cc malb added

comment:5 Changed 3 years ago by malb

  • Report Upstream changed from N/A to Fixed upstream, but not in a stable release.
  • Status changed from needs_review to positive_review

Thanks. I need to cut a new release for this.

comment:6 Changed 3 years ago by vbraun

  • Status changed from positive_review to needs_work

Reviewer name is missing...

comment:7 Changed 3 years ago by jdemeyer

  • Reviewers set to Martin Albrecht
  • Status changed from needs_work to positive_review

comment:8 Changed 3 years ago by malb

Sorry! I'm getting rusty at this.

comment:9 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/fpylll__add_patch_for_cython_3_0 to 5eee85087e4205686de824ff40da5d6d5beb6051
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.