Opened 2 years ago

Closed 2 years ago

#27246 closed enhancement (fixed)

py3: fix doctests in generic_graph (part 10) -- is_isomorphic

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords: py3, graph
Cc: Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 4c3cc7b (Commits, GitHub, GitLab) Commit: 4c3cc7b727043b271f54f87dd736cbe0606fbba4
Dependencies: Stopgaps:

Status badges

Description

2 failing doctests were due to the presence of \I in a graph6 string. This is fixed using \\I. On the way we reformat the graph6 string in 80 columns mode.

The other failing doctest is due to the test 

if edge_labels and sorted(self.edge_labels()) != sorted(other.edge_labels()):

This issue was also reported in #27232 with an example failing in both py2 and py3. So it's resolution is done in #27232.

Change History (3)

comment:1 Changed 2 years ago by dcoudert

  • Authors set to David Coudert
  • Branch set to u/dcoudert/27246_is_isomorphic
  • Commit set to 4c3cc7b727043b271f54f87dd736cbe0606fbba4
  • Keywords py3 graph added
  • Status changed from new to needs_review

New commits:

​4c3cc7btrac #27246: fix 2 doctests in is_isomorphic

comment:2 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:3 Changed 2 years ago by vbraun

  • Branch changed from u/dcoudert/27246_is_isomorphic to 4c3cc7b727043b271f54f87dd736cbe0606fbba4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.