Opened 4 months ago

Closed 4 months ago

#27242 closed enhancement (fixed)

py3: strengthen a doctest in vertex_separation.pyx

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords: py3, graph
Cc: Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 42dc1a5 (Commits) Commit: 42dc1a54b65323cd86bdf83f2dc353d4320c32e8
Dependencies: Stopgaps:

Description

The order in which solutions are found by the branch and bound algorithm depends on the order in which vertices are visited. Hence, this test sometimes answers 10 and some other times 11, and both answers are correct.

sage: from sage.graphs.graph_decompositions import vertex_separation as VS
sage: G = graphs.MycielskiGraph(5)
sage: vs, seq = VS.vertex_separation_BAB(G, cut_off=11); vs
10 or 11

We change it to a robust form

sage: VS.vertex_separation_BAB(G, cut_off=11)[0] <= 11
True

Change History (3)

comment:1 Changed 4 months ago by dcoudert

  • Branch set to u/dcoudert/27242_vertex_separation
  • Commit set to 42dc1a54b65323cd86bdf83f2dc353d4320c32e8
  • Status changed from new to needs_review

New commits:

42dc1a5trac #27242: strengthen doctests

comment:2 Changed 4 months ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok

comment:3 Changed 4 months ago by vbraun

  • Branch changed from u/dcoudert/27242_vertex_separation to 42dc1a54b65323cd86bdf83f2dc353d4320c32e8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.