Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#27238 closed enhancement (fixed)

use system's gf2x if available

Reported by: dimpase Owned by:
Priority: major Milestone: sage-8.7
Component: packages: standard Keywords: spkg-configure
Cc: embray, fbissey Merged in:
Authors: Dima Pasechnik Reviewers: François Bissey
Report Upstream: N/A Work issues:
Branch: 844e241 (Commits, GitHub, GitLab) Commit:
Dependencies: Stopgaps:

Status badges

Description

the usual spkg-configure.m4 thing

Change History (15)

comment:1 Changed 3 years ago by dimpase

  • Summary changed from use system't gf2x if available to use system's gf2x if available

comment:2 Changed 3 years ago by dimpase

the test is not sufficient to tell version 1.2 from 1.1

comment:3 Changed 3 years ago by dimpase

  • Keywords spkg-configure added

comment:4 Changed 3 years ago by dimpase

  • Dependencies set to #27212

comment:5 Changed 3 years ago by dimpase

One ought to be able to test for signature of a particular function in gf2x.h, which changed from 1.1 to 1.2.

comment:6 Changed 3 years ago by git

  • Commit changed from dbd74764d447e4d87e56067f2d5abc8fe95abc7f to 6b611568cd66bf66025b86b5ac3f535ac4126339

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a1ee9bdspkg-configure.m4 for gf2x
6b61156added a test for version >= 1.2

comment:7 Changed 3 years ago by dimpase

  • Status changed from new to needs_review

gf2x takes long time to build, as it does tuning, so that's quite a building speedup.

comment:8 Changed 3 years ago by dimpase

  • Dependencies #27212 deleted

comment:9 Changed 3 years ago by dimpase

  • Cc fbissey added

comment:10 Changed 3 years ago by fbissey

Is there a mix of tabs and white spaces in that file? Just looking at it in the browser, I didn't checkout the branch. Other than that it looks sound and should do the trick.

comment:11 Changed 3 years ago by git

  • Commit changed from 6b611568cd66bf66025b86b5ac3f535ac4126339 to 844e24113ea61ee3a6fd51c8119e32cb3e3ed40d

Branch pushed to git repo; I updated commit sha1. New commits:

844e241whitespaces adjusted, tabs removed

comment:12 Changed 3 years ago by dimpase

fixed whitespaces now, sorry.

comment:13 Changed 3 years ago by fbissey

  • Reviewers set to François Bissey
  • Status changed from needs_review to positive_review

Those things are quite clear on the diff but I think they are harmless in M4. Let's move on.

comment:14 Changed 3 years ago by vbraun

  • Branch changed from u/dimpase/packages/gf2x-config to 844e24113ea61ee3a6fd51c8119e32cb3e3ed40d
  • Resolution set to fixed
  • Status changed from positive_review to closed

comment:15 Changed 3 years ago by dimpase

  • Commit 844e24113ea61ee3a6fd51c8119e32cb3e3ed40d deleted

I've provided the upstream with a PR to do a pkg-config configuration, so this could be simplified eventually. See https://github.com/dimpase/gf2x/commit/c7cd1f26d193c8e2ee8a3648d6701231c14e29be and https://gforge.inria.fr/tracker/index.php?func=detail&aid=21746&group_id=1874&atid=6979

Note: See TracTickets for help on using tickets.