Opened 3 years ago
Closed 3 years ago
#27234 closed defect (fixed)
Implement method `gap` of class `PermutationGroupElement` properly.
Reported by: | soehms | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.7 |
Component: | group theory | Keywords: | libgap, permutation |
Cc: | Merged in: | ||
Authors: | Sebastian Oehms | Reviewers: | Travis Scrimshaw |
Report Upstream: | N/A | Work issues: | |
Branch: | 0e444c5 (Commits, GitHub, GitLab) | Commit: | 0e444c5f7aca9c3ac803bb7d8976db9212b9830a |
Dependencies: | Stopgaps: |
Description
This is a follow up ticket of #26750. In that ticket the method has been implemented as synonym of _gap_
, since at that time libgap produced an error for large permutations.
┌────────────────────────────────────────────────────────────────────┐ │ SageMath version 8.5, Release Date: 2018-12-22 │ │ Using Python 2.7.15. Type "help()" for help. │ └────────────────────────────────────────────────────────────────────┘ sage: P = PGU(8,2) sage: p1, p2 = P.gens() sage: libgap(p1) python2: libgap.c:184: libgap_get_input: Assertion `strlen(libGAP_stdin_buffer) < length' failed. Traceback (most recent call last): ... ValueError: libGAP: Aborted
This error has been fixed in 8.6.beta0. Therefore, we may have gap
using libgap
, right now!
Change History (5)
comment:1 Changed 3 years ago by
- Branch set to u/soehms/permgroup_element_gap_meth
comment:2 Changed 3 years ago by
- Commit set to 0e444c5f7aca9c3ac803bb7d8976db9212b9830a
- Status changed from new to needs_review
comment:3 Changed 3 years ago by
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to positive_review
LGTM.
comment:4 Changed 3 years ago by
Thanks!
comment:5 Changed 3 years ago by
- Branch changed from u/soehms/permgroup_element_gap_meth to 0e444c5f7aca9c3ac803bb7d8976db9212b9830a
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
New commits:
27234: initial version