Changes between Version 1 and Version 2 of Ticket #27212, comment 91


Ignore:
Timestamp:
04/10/19 12:30:17 (3 years ago)
Author:
embray
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27212, comment 91

    v1 v2  
    1 I don't think the nesting is necessary.  If finding the headers fails then it will set `sage_spkg_install_mpir=yes`; there's no advantage to then skipping the library check because it will still keep  and just makes the code harder to read IMO.
     1I don't think the nesting is necessary.  If finding the headers fails then it will set `sage_spkg_install_mpir=yes`; there's no advantage to then skipping the library check because it will still keep `sage_spkg_install_mpir=yes` reagardless. Nesting it just makes the code harder to read IMO.
    22
    33> And, by the way, what's that break doing there? I gather it's to interrupt loops, but there is no loop here...