Opened 3 years ago

Closed 3 years ago

#27211 closed defect (fixed)

Simplicial complexes: correct the documentation

Reported by: jhpalmieri Owned by:
Priority: minor Milestone: sage-8.7
Component: algebraic topology Keywords: simplicial complex
Cc: Merged in:
Authors: John Palmieri Reviewers: Darij Grinberg
Report Upstream: N/A Work issues:
Branch: 6ae1ee3 (Commits, GitHub, GitLab) Commit: 6ae1ee38fc76dc6b0b70aef3fdb8d958350275b0
Dependencies: Stopgaps:

Status badges

Description

The documentation for simplicial complexes is outdated: it should say that the vertex set is determined automatically from the facets (as their union).

Change History (9)

comment:1 Changed 3 years ago by jhpalmieri

  • Branch set to u/jhpalmieri/simplicial-docs

comment:2 Changed 3 years ago by jhpalmieri

  • Commit set to 15ee788e92bec980c6592fad0756d950f77a6f14
  • Status changed from new to needs_review

New commits:

15ee788trac 27211: in a simplicial complex, the vertex set is determined

comment:3 Changed 3 years ago by gh-darijgr

+   automatically: `V` is defined to be the union of the sets `K`. So

->

+   automatically: `V` is defined to be the union of the sets in `K`. So

===

+simplicial complex, specify its *facets*: the maximal subsets (with
+respect to inclusion) of the vertex set. Each facet can be specifed as

->

+simplicial complex, specify its *facets*: the maximal subsets (with
+respect to inclusion) of the vertex set that belong to `K`. Each facet can be specifed as

=== Other than this, LGTM if the doc compiles (I don't have Sage installed, so I can't check) and if your claim about maximal_faces being a number is true (is there a doctest?).

comment:4 Changed 3 years ago by jhpalmieri

Lines 980-981:

            sage: SimplicialComplex([2])
            Simplicial complex with vertex set (0, 1, 2) and facets {(0, 1, 2)}

comment:5 Changed 3 years ago by gh-darijgr

Ah, perfect.

comment:6 Changed 3 years ago by git

  • Commit changed from 15ee788e92bec980c6592fad0756d950f77a6f14 to 6ae1ee38fc76dc6b0b70aef3fdb8d958350275b0

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

6ae1ee3trac 27211: in a simplicial complex, the vertex set is determined

comment:7 Changed 3 years ago by jhpalmieri

I made the other changes, too.

comment:8 Changed 3 years ago by gh-darijgr

  • Keywords simplicial complex added
  • Reviewers set to Darij Grinberg
  • Status changed from needs_review to positive_review

LGTM, thanks!

comment:9 Changed 3 years ago by vbraun

  • Branch changed from u/jhpalmieri/simplicial-docs to 6ae1ee38fc76dc6b0b70aef3fdb8d958350275b0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.