Opened 4 years ago

Closed 4 years ago

Simplicial complexes: correct the documentation

Reported by: Owned by: John Palmieri minor sage-8.7 algebraic topology simplicial complex John Palmieri Darij Grinberg N/A 6ae1ee3 6ae1ee38fc76dc6b0b70aef3fdb8d958350275b0

Description

The documentation for simplicial complexes is outdated: it should say that the vertex set is determined automatically from the facets (as their union).

comment:1 Changed 4 years ago by John Palmieri

Branch: → u/jhpalmieri/simplicial-docs

comment:2 Changed 4 years ago by John Palmieri

Commit: → 15ee788e92bec980c6592fad0756d950f77a6f14 new → needs_review

New commits:

 ​15ee788 `trac 27211: in a simplicial complex, the vertex set is determined`

comment:3 Changed 4 years ago by Darij Grinberg

```+   automatically: `V` is defined to be the union of the sets `K`. So
```

->

```+   automatically: `V` is defined to be the union of the sets in `K`. So
```

===

```+simplicial complex, specify its *facets*: the maximal subsets (with
+respect to inclusion) of the vertex set. Each facet can be specifed as
```

->

```+simplicial complex, specify its *facets*: the maximal subsets (with
+respect to inclusion) of the vertex set that belong to `K`. Each facet can be specifed as
```

=== Other than this, LGTM if the doc compiles (I don't have Sage installed, so I can't check) and if your claim about `maximal_faces` being a number is true (is there a doctest?).

comment:4 Changed 4 years ago by John Palmieri

Lines 980-981:

```            sage: SimplicialComplex([2])
Simplicial complex with vertex set (0, 1, 2) and facets {(0, 1, 2)}
```

Ah, perfect.

comment:6 Changed 4 years ago by git

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

 ​6ae1ee3 `trac 27211: in a simplicial complex, the vertex set is determined`

comment:7 Changed 4 years ago by John Palmieri

I made the other changes, too.

comment:8 Changed 4 years ago by Darij Grinberg

Keywords: simplicial complex added → Darij Grinberg needs_review → positive_review

LGTM, thanks!

comment:9 Changed 4 years ago by Volker Braun

Branch: u/jhpalmieri/simplicial-docs → 6ae1ee38fc76dc6b0b70aef3fdb8d958350275b0 → fixed positive_review → closed
Note: See TracTickets for help on using tickets.