Opened 4 years ago

Closed 4 years ago

#27184 closed enhancement (fixed)

py3: fix doctests in generic_graph (part 6) -- graphviz_string

Reported by: David Coudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords: py3, graph
Cc: Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 47f965f (Commits, GitHub, GitLab) Commit: 47f965f33733b7cef8b7a57ec26ef4d1e9a52dc6
Dependencies: Stopgaps:

Status badges

Description

Fix doctests in

  • _keys_for_vertices: one doctest is fixed adding a .... The other is fixed by removing the call to .vertices() in the method (his is safe for the result of graphviz_string.
  • graphviz_string: we change the failing doctest by something more stable when marked py3 (again an issue of ordering of vertices and edges)

Change History (6)

comment:1 Changed 4 years ago by David Coudert

Branch: public/27184_generic_graph_6
Commit: 496577acabfc60708538922eaad62c82034f1e99
Status: newneeds_review

New commits:

496577atrac #27184: fix doctests in graphviz_string and _keys_for_vertices

comment:2 Changed 4 years ago by Frédéric Chapoton

failing doctest, see patchbot

comment:3 Changed 4 years ago by git

Commit: 496577acabfc60708538922eaad62c82034f1e9947f965f33733b7cef8b7a57ec26ef4d1e9a52dc6

Branch pushed to git repo; I updated commit sha1. New commits:

47f965ftrac #27184: fix py2 doctest

comment:4 Changed 4 years ago by David Coudert

Right, it was not the correct py2 output. Now corrected.

comment:5 Changed 4 years ago by Frédéric Chapoton

Reviewers: Frédéric Chapoton
Status: needs_reviewpositive_review

ok, then

comment:6 Changed 4 years ago by Volker Braun

Branch: public/27184_generic_graph_647f965f33733b7cef8b7a57ec26ef4d1e9a52dc6
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.