#27182 closed enhancement (fixed)
spkg-configure.m4 for bzip2
Reported by: | embray | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.7 |
Component: | packages: standard | Keywords: | spkg-configure |
Cc: | Merged in: | ||
Authors: | Erik Bray, Dima Pasechnik | Reviewers: | Dima Pasechnik |
Report Upstream: | N/A | Work issues: | |
Branch: | 4ec5dc0 (Commits, GitHub, GitLab) | Commit: | |
Dependencies: | Stopgaps: |
Description
Spun off from #27168.
Change History (14)
comment:1 Changed 3 years ago by
- Status changed from new to needs_review
comment:2 Changed 3 years ago by
For testing tickets like this it's best to start from a fresh install, since otherwise I think, even if the ./configure
script now detects your system's bzip2, it's not like it will uninstall the package already installed spkg.
comment:3 Changed 3 years ago by
Tested a fresh build and ptestlong
with my system's bzip2 (also 1.0.6). Actually, I think this software's creator has stopped maintaining it. There was some discussion about that a bit ago on the Cygwin mailing list IIRC.
comment:4 Changed 3 years ago by
the branch does not seem to contain spkg-configure.m4 :-) (at least using the trac view)
No, it's just not there. Forgotten commit?
comment:5 Changed 3 years ago by
comment:6 Changed 3 years ago by
Lol. Must be a forgotten git add
.
comment:7 Changed 3 years ago by
- Commit changed from 0cb494282d7b4cea50aba7f4d100e7932a4c00b1 to 4ec5dc0850c9ae65cf40d5dc53896ca8028c5203
Branch pushed to git repo; I updated commit sha1. New commits:
4ec5dc0 | Trac #27182: add configure-time detection of the system's libbz2
|
comment:8 Changed 3 years ago by
looks good to me. See #27212 for ditto for GMP, by the way.
comment:9 Changed 3 years ago by
- Reviewers set to Dima Pasechnik
- Status changed from needs_review to positive_review
comment:10 Changed 3 years ago by
- Branch changed from u/embray/build/bzip2-spkg-configure to 4ec5dc0850c9ae65cf40d5dc53896ca8028c5203
- Resolution set to fixed
- Status changed from positive_review to closed
comment:11 Changed 3 years ago by
- Commit 4ec5dc0850c9ae65cf40d5dc53896ca8028c5203 deleted
- Keywords spkg-configure added
comment:12 follow-up: ↓ 13 Changed 2 years ago by
Sanity check: does that last AC_CHECK_PROG really do what it's supposed to?
SAGE_SPKG_CONFIGURE([bzip2], [ AC_CHECK_HEADER(bzlib.h, [], [sage_spkg_install_bzip2=yes]) AC_SEARCH_LIBS([BZ2_bzCompress], [bz2], [], [sage_spkg_install_bzip2=yes]) AC_CHECK_PROG(bzip2, [break], [sage_spkg_install_bzip2=yes]) ])
comment:13 in reply to: ↑ 12 Changed 2 years ago by
Replying to mjo:
Sanity check: does that last AC_CHECK_PROG really do what it's supposed to?
SAGE_SPKG_CONFIGURE([bzip2], [ AC_CHECK_HEADER(bzlib.h, [], [sage_spkg_install_bzip2=yes]) AC_SEARCH_LIBS([BZ2_bzCompress], [bz2], [], [sage_spkg_install_bzip2=yes]) AC_CHECK_PROG(bzip2, [break], [sage_spkg_install_bzip2=yes]) ])
hmm, no. It should be AC_PATH_PROG([BZIP2], [bzip2], [sage_spkg_install_bzip2=yes])
- the test as specified always passes.
comment:14 Changed 2 years ago by
I've opened #28956 to deal with it.
This also reminds me, we probably should add a section in the installation docs (especially for Linux) listing optional
-devel
packages that should be installed in order to take advantage of supported system packages where possible.