Opened 2 years ago

Closed 2 years ago

#27181 closed enhancement (fixed)

py3: fix doctest in generic_graph (part 4)

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords: py3, graph
Cc: Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 2151286 (Commits, GitHub, GitLab) Commit: 2151286bc4855eedf4d8ddd50ac7643aee6fef3c
Dependencies: Stopgaps:

Status badges

Description

Fix doctests in:

  • vertex_boundary. We now sort the output in the doctest
  • neighbor_iterator: again this is due to the use of set in _backend.iterator_nbrs leading to different orderings in py2 and py3. We change the example to a more stable one
  • degree: we mark doctests as py2 and py3
  • degree_iterator: we mark doctests as py2 and py3

Change History (3)

comment:1 Changed 2 years ago by dcoudert

  • Branch set to public/27181_generic_graph_4
  • Commit set to 2151286bc4855eedf4d8ddd50ac7643aee6fef3c
  • Status changed from new to needs_review

New commits:

​2151286trac #27181: fix some more doctests in generic_graph.py

comment:2 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok, ok. I am slightly worried by the proliferation of #py2 / #py3 tags, but agree that once we tried hard to do otherwise, it's ok.

comment:3 Changed 2 years ago by vbraun

  • Branch changed from public/27181_generic_graph_4 to 2151286bc4855eedf4d8ddd50ac7643aee6fef3c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.