Opened 18 months ago

Closed 18 months ago

#27179 closed enhancement (fixed)

py3: fix doctest in generic_graph (part 2) -- cycle_basis

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords: py3, graph
Cc: Merged in:
Authors: David Coudert Reviewers: Jean-Florent Raymond
Report Upstream: N/A Work issues:
Branch: 8136fe7 (Commits) Commit: 8136fe70ee76b1bd5095d65ea56656b70b5677ae
Dependencies: Stopgaps:

Description

Some difficulties are that 1) the method of networkx that we use can either return cycle [0, 1, 2, 3, 0] or cycle [0, 3, 2, 1, 0], and 2) the cycle basis is not unique. So we mark doctests as py3 or py3.

Change History (4)

comment:1 Changed 18 months ago by dcoudert

  • Branch set to public/27179_cycle_basis
  • Commit set to 7995a07e0eb51747cc944d18e6ddb12a93dd1837
  • Status changed from new to needs_review

New commits:

​7995a07trac #27179: fix doctests in cycle_basis

comment:2 Changed 18 months ago by git

  • Commit changed from 7995a07e0eb51747cc944d18e6ddb12a93dd1837 to 8136fe70ee76b1bd5095d65ea56656b70b5677ae

Branch pushed to git repo; I updated commit sha1. New commits:

​8136fe7trac #27179: revert suppression of empty line to avoid conflict with 27180

comment:3 Changed 18 months ago by gh-jfraymond

  • Reviewers set to Jean-Florent Raymond
  • Status changed from needs_review to positive_review

OK

comment:4 Changed 18 months ago by vbraun

  • Branch changed from public/27179_cycle_basis to 8136fe70ee76b1bd5095d65ea56656b70b5677ae
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.