Opened 4 years ago

Last modified 2 years ago

#27171 closed defect

Move files used by sage at import time to live inside the package — at Version 5

Reported by: Erik Bray Owned by:
Priority: major Milestone: sage-9.2
Component: refactoring Keywords:
Cc: François Bissey, Timo Kaufmann, John Palmieri, Frédéric Chapoton Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Jeroen Demeyer)

Non-binary files that are part of the sage sources and needed by the sage package at import time should be installed in the package, using package_data in setup.py. See e.g. https://trac.sagemath.org/ticket/27040#comment:48

Change History (5)

comment:1 Changed 4 years ago by François Bissey

Cc: François Bissey added

comment:2 Changed 4 years ago by Timo Kaufmann

Cc: Timo Kaufmann added

comment:3 Changed 4 years ago by Jeroen Demeyer

(edit: never mind)

Last edited 4 years ago by Jeroen Demeyer (previous) (diff)

comment:4 Changed 4 years ago by Jeroen Demeyer

Replying to embray:

If it's needed by the sage Python package to work then it should just be installed inside the package (e.g. as package_data in setup.py)

Why should it be installed like that?

I'm not against moving the specific file sage-maxima.lisp, but you seem to imply a more general rule here that Python packages should never access files outside of their own package (or something like that?).

comment:5 Changed 4 years ago by Jeroen Demeyer

Description: modified (diff)
Note: See TracTickets for help on using tickets.