Opened 5 months ago

Closed 4 months ago

#27166 closed enhancement (fixed)

remove deprecated classes NetworkXGraphDeprecated and NetworkXDiGraphDeprecated

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords: py3, graph
Cc: tscrim, chapoton Merged in:
Authors: David Coudert Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: aeddfdf (Commits) Commit: aeddfdf4900dfc3883ae59c245a0e53c57e784a1
Dependencies: Stopgaps:

Description

The 2 classes contains a deprecation warning since at least #10900 (from 2011), and classes XGraph and XDiGraph have been replaced by class MultiGraph and MultiDiGraph in NetworkX 0.99 released in 2008. So it's time to remove these classes from file src/sage/graphs/base/graph_backends.pyx.

Furthermore, this fix the doctest error with py3 in graph_backends.pyx.

Change History (3)

comment:1 Changed 5 months ago by dcoudert

  • Branch set to public/27166_graph_backends
  • Cc tscrim chapoton added
  • Commit set to aeddfdf4900dfc3883ae59c245a0e53c57e784a1
  • Status changed from new to needs_review

New commits:

​aeddfdftrac #27166: remove deprecated classes NetworkXGraphDeprecated and NetworkXDiGraphDeprecated

comment:2 Changed 5 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:3 Changed 4 months ago by vbraun

  • Branch changed from public/27166_graph_backends to aeddfdf4900dfc3883ae59c245a0e53c57e784a1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.