Opened 18 months ago
Closed 12 months ago
#27161 closed defect (fixed)
Documentation for Tate algebras
Reported by:  caruso  Owned by:  

Priority:  major  Milestone:  sage8.9 
Component:  documentation  Keywords:  
Cc:  TristanVaccon, ghThibautVerron, caruso, roed, tscrim, vklein  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  cab69cb (Commits)  Commit:  cab69cbe4b9ff45b6ba4e36933d439009ef55107 
Dependencies:  Stopgaps: 
Description
The documentation for Tate algebras is not included in the reference manual: https://doc.sagemath.org/html/en/reference/index.html
Change History (15)
comment:1 Changed 18 months ago by
 Status changed from new to needs_info
comment:2 Changed 16 months ago by
 Milestone changed from sage8.7 to sage8.8
Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)
comment:3 Changed 13 months ago by
 Milestone changed from sage8.8 to sage8.9
Tickets still needing working or clarification should be moved to the next release milestone at the soonest (please feel free to revert if you think the ticket is close to being resolved).
comment:4 Changed 13 months ago by
 Branch set to public/ticket/27161
 Commit set to 73b8a3ef085791edceb00e033e3e9af29d9dd808
 Status changed from needs_info to needs_review
New commits:
73b8a3e  add Tate algebras to the doc

comment:5 Changed 13 months ago by
comment:7 Changed 13 months ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
LGTM.
comment:8 followup: ↓ 9 Changed 13 months ago by
I have a quick question regarding the milestone. Given that the ticket is accepted now, will it be part of the 8.8 release?
Or should we change the milestone for that? Or is it too late in any case?
comment:9 in reply to: ↑ 8 ; followup: ↓ 14 Changed 13 months ago by
Replying to ghThibautVerron:
I have a quick question regarding the milestone. Given that the ticket is accepted now, will it be part of the 8.8 release?
NO. 8.8 is finished.
Or should we change the milestone for that? Or is it too late in any case?
No need to change the milestone. But you can if you want. Keeping 8.8 as milestone does not prevent the ticket to be closed in some 8.9 beta release.
comment:10 Changed 13 months ago by
 Status changed from positive_review to needs_work
PDF docs don't build
[docpdf] Chapter 12. [docpdf] ! Undefined control sequence. [docpdf] l.7785 \(\val [docpdf] (x_i) \geq v_i\) for all \(i \in \{1,\dots,n\}\). The \(v_i\)�... [docpdf] [docpdf] ? [docpdf] ! Emergency stop. [docpdf] l.7785 \(\val [docpdf] (x_i) \geq v_i\) for all \(i \in \{1,\dots,n\}\). The \(v_i\)�... [docpdf] [docpdf] ! ==> Fatal error occurred, no output PDF file produced! [docpdf] Transcript written on power_series.log. [docpdf] Latexmk: Index file 'power_series.idx' was written
comment:11 Changed 13 months ago by
 Commit changed from 73b8a3ef085791edceb00e033e3e9af29d9dd808 to cab69cbe4b9ff45b6ba4e36933d439009ef55107
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
cab69cb  add Tate algebras to the doc

comment:14 in reply to: ↑ 9 Changed 12 months ago by
Replying to chapoton:
No need to change the milestone. But you can if you want. Keeping 8.8 as milestone does not prevent the ticket to be closed in some 8.9 beta release.
I disagree. The milestone should be changed. It should have been changed before 8.8 even went into release candidate stage. I would like to push us more towards using release milestones properly; as we use them currently they are not useful.
comment:15 Changed 12 months ago by
 Branch changed from public/ticket/27161 to cab69cbe4b9ff45b6ba4e36933d439009ef55107
 Resolution set to fixed
 Status changed from positive_review to closed
I'm not sure where we should put this documentation. In the section
Basic Rings and Fields
? In the sectionAlgebraic and Arithmetic Geometry
(since Tate algebras are building blocks for rigid varieties)? Elsewhere?