Opened 4 years ago
Closed 4 years ago
#27160 closed enhancement (fixed)
py3: fix doctests in hyperbolicity and graph_coloring
| Reported by: | David Coudert | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-8.7 |
| Component: | graph theory | Keywords: | py3, graph |
| Cc: | Merged in: | ||
| Authors: | David Coudert | Reviewers: | Jean-Florent Raymond |
| Report Upstream: | N/A | Work issues: | |
| Branch: | c3678ad (Commits, GitHub, GitLab) | Commit: | c3678ad59f8aa6e372aeeefa6bd363fc49f4218b |
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
hyperbolicity: we avoid sorting vertex ids before returning the certificate, and we sort these ids in the doctests.graph_coloring: we sort the output of some doctests
Change History (8)
comment:1 Changed 4 years ago by
| Branch: | → u/dcoudert/27160_hyperbolicity_and_graph_coloring |
|---|---|
| Commit: | → 4784cc285c52df637154e83ba063bb6ba652ed74 |
| Status: | new → needs_review |
comment:2 Changed 4 years ago by
| Commit: | 4784cc285c52df637154e83ba063bb6ba652ed74 → 2490bc9b883bb758e405eb4ee81caf4ad3df707b |
|---|
comment:3 Changed 4 years ago by
| Commit: | 2490bc9b883bb758e405eb4ee81caf4ad3df707b → c3678ad59f8aa6e372aeeefa6bd363fc49f4218b |
|---|
Branch pushed to git repo; I updated commit sha1. New commits:
| c3678ad | trac #27160: avoid another py2/py3 tag in graph_coloring
|
comment:4 Changed 4 years ago by
| Description: | modified (diff) |
|---|
I changed the proposed fixes to avoid # py2 and #py 3 tags.
hyperbolicity: it is more robust to avoid sorting vertex ids of the certificate before returning it, and to sort these ids in the doctestsgraph_coloring: we now sort the output of some doctests
comment:5 Changed 4 years ago by
Note that the lines you edited about approximation of hyperbolicity for grids an cycles now go over 80 characters. (also true for other lines of both files, but outside of the aim of this ticket)
Is it a problem? If not I am fine with the patch.
comment:7 Changed 4 years ago by
| Reviewers: | → Jean-Florent Raymond |
|---|---|
| Status: | needs_review → positive_review |
comment:8 Changed 4 years ago by
| Branch: | u/dcoudert/27160_hyperbolicity_and_graph_coloring → c3678ad59f8aa6e372aeeefa6bd363fc49f4218b |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
hyperbolicity: mark doctest as py2 and py3graph_coloring: mark doctest as py2 and py3