Opened 4 years ago
Closed 4 years ago
#27159 closed enhancement (fixed)
py3: fix doctests in strongly_regular_db.pyx
| Reported by: | David Coudert | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | sage-8.7 |
| Component: | graph theory | Keywords: | py3, graph |
| Cc: | Merged in: | ||
| Authors: | David Coudert | Reviewers: | Frédéric Chapoton |
| Report Upstream: | N/A | Work issues: | |
| Branch: | 9428da9 (Commits, GitHub, GitLab) | Commit: | 9428da9cd926f3f9a33dc3dc46f8ac0a3ed62c1c |
| Dependencies: | Stopgaps: |
Status badges
Description
The construction of SRG_196_91_42_42() was not correct in py3 due to the change of behavior of map that is now a one time iterator.
also, mark one doctest as py2 and py3.
Change History (5)
comment:1 Changed 4 years ago by
| Branch: | → u/dcoudert/27159_strongly_regular_db |
|---|---|
| Commit: | → 9428da9cd926f3f9a33dc3dc46f8ac0a3ed62c1c |
| Status: | new → needs_review |
comment:2 Changed 4 years ago by
| Reviewers: | → Frédéric Chapoton |
|---|---|
| Status: | needs_review → positive_review |
ok. Although some other people dislike very much the use of list(map(...)) which is indeed ugly.
comment:3 Changed 4 years ago by
If you prefer, I can rewrite it as A = [frozenset([x + z for x in A]) for z in G].
comment:5 Changed 4 years ago by
| Branch: | u/dcoudert/27159_strongly_regular_db → 9428da9cd926f3f9a33dc3dc46f8ac0a3ed62c1c |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
New commits:
fix construction of SRG_196_91_42_42() due to behavior change of mapmark a doctest with py2 and py3 in is_twograph_descendant_of_srg