Opened 2 years ago

Closed 2 years ago

#27159 closed enhancement (fixed)

py3: fix doctests in strongly_regular_db.pyx

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords: py3, graph
Cc: Merged in:
Authors: David Coudert Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: 9428da9 (Commits, GitHub, GitLab) Commit: 9428da9cd926f3f9a33dc3dc46f8ac0a3ed62c1c
Dependencies: Stopgaps:

Status badges

Description

The construction of SRG_196_91_42_42() was not correct in py3 due to the change of behavior of map that is now a one time iterator.

also, mark one doctest as py2 and py3.

Change History (5)

comment:1 Changed 2 years ago by dcoudert

  • Branch set to u/dcoudert/27159_strongly_regular_db
  • Commit set to 9428da9cd926f3f9a33dc3dc46f8ac0a3ed62c1c
  • Status changed from new to needs_review

New commits:

​3383b8afix construction of SRG_196_91_42_42() due to behavior change of map
​9428da9mark a doctest with py2 and py3 in is_twograph_descendant_of_srg

comment:2 Changed 2 years ago by chapoton

  • Reviewers set to Frédéric Chapoton
  • Status changed from needs_review to positive_review

ok. Although some other people dislike very much the use of list(map(...)) which is indeed ugly.

comment:3 Changed 2 years ago by dcoudert

If you prefer, I can rewrite it as A = [frozenset([x + z for x in A]) for z in G].

comment:4 Changed 2 years ago by chapoton

bah, pas la peine. Une autre fois

comment:5 Changed 2 years ago by vbraun

  • Branch changed from u/dcoudert/27159_strongly_regular_db to 9428da9cd926f3f9a33dc3dc46f8ac0a3ed62c1c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.