Opened 2 years ago

Closed 2 years ago

#27149 closed enhancement (fixed)

py3: fix doctests in comparability.pyx

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords: py3, graph
Cc: Merged in:
Authors: David Coudert Reviewers: Vincent Klein
Report Upstream: N/A Work issues:
Branch: 7100e61 (Commits, GitHub, GitLab) Commit: 7100e61b6d5fd493761f149e39220d4c211054fd
Dependencies: Stopgaps:

Status badges

Description

We mark the 3 failing doctests as # py2 and add appropriate tests for # py3.

We also avoid using .edges(), and at least add it sort=False.

Change History (3)

comment:1 Changed 2 years ago by dcoudert

  • Branch set to u/dcoudert/27149_comparability
  • Commit set to 7100e61b6d5fd493761f149e39220d4c211054fd
  • Status changed from new to needs_review

New commits:

​7100e61trac #27149: fix comparability.pyx

comment:2 Changed 2 years ago by vklein

  • Reviewers set to Vincent Klein
  • Status changed from needs_review to positive_review

Looks good to me.

comment:3 Changed 2 years ago by vbraun

  • Branch changed from u/dcoudert/27149_comparability to 7100e61b6d5fd493761f149e39220d4c211054fd
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.