Opened 7 months ago

Closed 7 months ago

#27142 closed enhancement (fixed)

bunch of various bad things

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: refactoring Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: ad77950 (Commits) Commit: ad7795064009b86ad1ebd19d6b48d7ade8a1d9e7
Dependencies: Stopgaps:

Description

found by lgtm

Change History (7)

comment:1 Changed 7 months ago by chapoton

  • Branch set to u/chapoton/27142
  • Commit set to 517f163b6e0257b6abaa73d5ded493ccd80ba08e
  • Status changed from new to needs_review

New commits:

517f163bunch of various bad things found by lgtm

comment:2 Changed 7 months ago by tscrim

  • Reviewers set to Travis Scrimshaw

Green bot => positive review.

comment:3 Changed 7 months ago by chapoton

  • Status changed from needs_review to positive_review

thanks. Even faster than me..

comment:4 Changed 7 months ago by vbraun

  • Status changed from positive_review to needs_work

Merge conflict...

comment:5 Changed 7 months ago by git

  • Commit changed from 517f163b6e0257b6abaa73d5ded493ccd80ba08e to ad7795064009b86ad1ebd19d6b48d7ade8a1d9e7

Branch pushed to git repo; I updated commit sha1. New commits:

ad77950Merge branch 'u/chapoton/27142' in 8.7.b2

comment:6 Changed 7 months ago by chapoton

  • Status changed from needs_work to positive_review

fixed, setting back to positive

comment:7 Changed 7 months ago by vbraun

  • Branch changed from u/chapoton/27142 to ad7795064009b86ad1ebd19d6b48d7ade8a1d9e7
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.