Opened 3 years ago

Closed 3 years ago

#27137 closed enhancement (fixed)

pep8 in digraph_generators.py (part 4)

Reported by: dcoudert Owned by:
Priority: minor Milestone: sage-8.8
Component: graph theory Keywords:
Cc: Merged in:
Authors: David Coudert Reviewers: Kevin Dilks
Report Upstream: N/A Work issues:
Branch: 123fd1f (Commits, GitHub, GitLab) Commit: 123fd1f75b5670d7309f3cbb608491fe6ba63de9
Dependencies: Stopgaps:

Status badges

Description

Clean

  • RandomDirectedGNC
  • RandomDirectedGNM
  • RandomDirectedGNP
  • RandomDirectedGN
  • RandomDirectedGNR
  • RandomSemiComplete

and move some references to global references file.

Change History (7)

comment:1 Changed 3 years ago by dcoudert

  • Branch set to u/dcoudert/27137_digraph_generators_4
  • Commit set to d25f7eec5dd085b15b63aec3913f6c4cc9e28be8
  • Status changed from new to needs_review

New commits:

​d25f7eetrac #27137: clean digraph_generators part 4

comment:2 Changed 3 years ago by kdilks

  • Branch changed from u/dcoudert/27137_digraph_generators_4 to u/kdilks/27137_digraph_generators_4

comment:3 Changed 3 years ago by git

  • Commit changed from d25f7eec5dd085b15b63aec3913f6c4cc9e28be8 to 123fd1f75b5670d7309f3cbb608491fe6ba63de9

Branch pushed to git repo; I updated commit sha1. New commits:

​123fd1fFixed leftover merge commit line

comment:4 Changed 3 years ago by embray

  • Milestone changed from sage-8.7 to sage-8.8

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

comment:5 Changed 3 years ago by dcoudert

@kdilks: I'm not sure of what modifications you made to the code when you changed the branch, but the code looks good to me and the patchbot is green...

comment:6 Changed 3 years ago by kdilks

  • Reviewers set to Kevin Dilks
  • Status changed from needs_review to positive_review

I just did something dumb when I pulled to create a non-existent merge conflict.

Looks good to me.

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/kdilks/27137_digraph_generators_4 to 123fd1f75b5670d7309f3cbb608491fe6ba63de9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.