Opened 2 years ago

Last modified 2 years ago

#27135 closed enhancement

pep8 in digraph_generators.py (part 2) — at Version 6

Reported by: dcoudert Owned by:
Priority: minor Milestone: sage-8.7
Component: graph theory Keywords:
Cc: Merged in:
Authors: David Coudert Reviewers: Bryan Gin-ge Chen
Report Upstream: N/A Work issues:
Branch: u/dcoudert/27135_digraph_generators_2 (Commits, GitHub, GitLab) Commit: 3748045866e8d5412b8411d29b4da8f7d2199b0e
Dependencies: Stopgaps:

Status badges

Description (last modified by dcoudert)

Clean

  • Complete
  • Circuit
  • Circulant

In both Circuit and Circulant, we also avoid creating the list of edges before adding it to the digraph (small speed up)

Change History (6)

comment:1 Changed 2 years ago by dcoudert

  • Authors set to David Coudert
  • Branch set to u/dcoudert/27135_digraph_generators_2
  • Commit set to aaf7d592fd474670912e02c879fa02eba9542ee5
  • Status changed from new to needs_review

New commits:

aaf7d59trac #27135: clean digraph_generators part 2

comment:2 Changed 2 years ago by dcoudert

  • Type changed from PLEASE CHANGE to enhancement

comment:3 Changed 2 years ago by dcoudert

  • Priority changed from major to minor

comment:4 Changed 2 years ago by gh-bryangingechen

  • Reviewers set to Bryan Gin-ge Chen
  • Status changed from needs_review to needs_work

In the documentation of Circuit, there are missing periods at the ends of sentences.

In Circulant, the 3 occurrences of relative integers should just be integers (I guess this is a French-to-English thing).

Feel free to set to positive review after fixing.

Last edited 2 years ago by gh-bryangingechen (previous) (diff)

comment:5 Changed 2 years ago by git

  • Commit changed from aaf7d592fd474670912e02c879fa02eba9542ee5 to 3748045866e8d5412b8411d29b4da8f7d2199b0e

Branch pushed to git repo; I updated commit sha1. New commits:

2ac1095trac #27135: Merged with 8.7.beta1
3748045trac #27135: remove occurence of relative

comment:6 Changed 2 years ago by dcoudert

  • Description modified (diff)
  • Status changed from needs_work to positive_review

Thank you for the review.

Note: See TracTickets for help on using tickets.