Opened 5 months ago

Closed 5 months ago

#27125 closed enhancement (fixed)

py3: fix some doctests in graph.py

Reported by: dcoudert Owned by:
Priority: major Milestone: sage-8.7
Component: graph theory Keywords: py3, graph
Cc: Merged in:
Authors: David Coudert Reviewers: Vincent Klein
Report Upstream: N/A Work issues:
Branch: e5534bc (Commits) Commit: e5534bc5c3aafc5aa8d60490b4635a9f16af3328
Dependencies: Stopgaps:

Description

Fix failing doctests with Python3 in apex_vertices, coloring and matching.

File "src/sage/graphs/graph.py", line 2057, in sage.graphs.graph.Graph.apex_vertices
Failed example:
    G.apex_vertices()
Expected:
    ['x', (2, 2), (3, 3), (1, 1)]
Got:
    ['x', (1, 1), (3, 3), (2, 2)]
**********************************************************************
File "src/sage/graphs/graph.py", line 4158, in sage.graphs.graph.Graph.coloring
Failed example:
    P = G.coloring(algorithm="DLX"); P
Expected:
    [[1, 2, 3], [0, 5, 6], [4]]
Got:
    [[0, 5, 6], [1, 2, 3], [4]]
**********************************************************************
File "src/sage/graphs/graph.py", line 4458, in sage.graphs.graph.Graph.?
Failed example:
    g.matching(algorithm="LP")
Expected:
    [(2, 3, -5), (0, 1, 0)]
Got:
    [(0, 1, 0), (2, 3, -5)]

Change History (3)

comment:1 Changed 5 months ago by dcoudert

  • Branch set to public/27125_doctests_in_graph
  • Commit set to e5534bc5c3aafc5aa8d60490b4635a9f16af3328
  • Status changed from new to needs_review

New commits:

e5534bctrac #27125: fix some doctests for py3

comment:2 Changed 5 months ago by vklein

  • Reviewers set to Vincent Klein
  • Status changed from needs_review to positive_review

Looks good to me.

comment:3 Changed 5 months ago by vbraun

  • Branch changed from public/27125_doctests_in_graph to e5534bc5c3aafc5aa8d60490b4635a9f16af3328
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.