Changes between Version 2 and Version 9 of Ticket #27123


Ignore:
Timestamp:
Jan 25, 2019, 2:55:59 PM (4 years ago)
Author:
jdemeyer
Comment:

Replying to dcoudert:

According to the documentation, parameter domain must be a sorted list of integer

That documentation is just wrong... even the examples in that file have other domains. I decided that remove that piece of documentation: having wrong documentation is worse than no documentation at all.


New commits:

bb167c5bliss automorphism_group() shouldn't sort vertices

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27123

    • Property Status changed from new to needs_review
    • Property Branch changed from to u/jdemeyer/bliss_automorphism_group___shouldn_t_sort_vertices
    • Property Commit changed from to bb167c54b98ab2fbe9502c7d9b1e2813abf7fe1c
  • Ticket #27123 – Description

    v2 v9  
    1 This sorting was introduced in #25426. We need to revert that since vertices of graphs cannot be sorted in general.
     1This sorting was introduced in #25426 to fix a problem with `automorphisms_of_rows_and_columns`. Since sorting vertices of graphs is not possible in general, that needs to be reverted.
     2
     3In fact, the problem was not with bliss but with invalid assumptions made in the method `automorphisms_of_rows_and_columns`.
     4
     5So this ticket reverts the fix for #25426 and replaces it by a correct fix.