Opened 3 years ago

Closed 3 years ago

#27116 closed enhancement (invalid)

py3: fix some doctests in interacts

Reported by: chapoton Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: python3 Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

by wrapping range with list

Change History (5)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/27116
  • Commit set to 76afd5fa2b4efc55bb2b69c85a7dc567540ac62b
  • Status changed from new to needs_review

New commits:

​76afd5fpy3: fix some doctests in interacts library (range)

comment:2 Changed 3 years ago by jdemeyer

As you can probably guess, I don't like this change. It's again one of these cases where range(n) should just work and we shouldn't "fix" the code by using list(range(n)).

See #27117 for a real fix.

comment:3 Changed 3 years ago by jdemeyer

  • Status changed from needs_review to needs_work

comment:4 Changed 3 years ago by chapoton

  • Branch u/chapoton/27116 deleted
  • Commit 76afd5fa2b4efc55bb2b69c85a7dc567540ac62b deleted
  • Milestone changed from sage-8.7 to sage-duplicate/invalid/wontfix
  • Status changed from needs_work to positive_review

ok, the doctests in this file now pass.

please close as invalid

comment:5 Changed 3 years ago by embray

  • Resolution set to invalid
  • Status changed from positive_review to closed

Presuming these are all correctly reviewed as either duplicate, invalid, or wontfix.

Note: See TracTickets for help on using tickets.