Opened 3 years ago

Closed 3 years ago

#27108 closed enhancement (fixed)

some pyflakes cleanup for combinatorics

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: combinatorics Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: a50e1d3 (Commits, GitHub, GitLab) Commit: a50e1d3b03baf1ffb547c28c5151084a7ac16208
Dependencies: Stopgaps:

Status badges

Description

only partial still

Change History (8)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/27108
  • Commit set to ac42a2543007c23ade09e0102f5fa17b1485d69f
  • Status changed from new to needs_review

New commits:

​ac42a25some pyflakes cleanup in combinatorics (partial)

comment:2 Changed 3 years ago by git

  • Commit changed from ac42a2543007c23ade09e0102f5fa17b1485d69f to 4e24b217f3b370c2c11a57bb5bd3df7f23cfffa6

Branch pushed to git repo; I updated commit sha1. New commits:

​4e24b21one more little fix

comment:3 Changed 3 years ago by git

  • Commit changed from 4e24b217f3b370c2c11a57bb5bd3df7f23cfffa6 to bd4d4c6eecc31c8b8e2de70a1dbd3fb0f66982a4

Branch pushed to git repo; I updated commit sha1. New commits:

​bd4d4c6fix import

comment:4 Changed 3 years ago by git

  • Commit changed from bd4d4c6eecc31c8b8e2de70a1dbd3fb0f66982a4 to a50e1d3b03baf1ffb547c28c5151084a7ac16208

Branch pushed to git repo; I updated commit sha1. New commits:

​a50e1d3better doctests

comment:5 Changed 3 years ago by chapoton

green bot, please review

comment:6 Changed 3 years ago by chapoton

  • Cc tscrim added

comment:7 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/27108 to a50e1d3b03baf1ffb547c28c5151084a7ac16208
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.