Opened 3 years ago

Closed 3 years ago

#27107 closed defect (fixed)

py3: fix bad relative import in elliptic curves

Reported by: chapoton Owned by:
Priority: critical Milestone: sage-8.7
Component: python3 Keywords:
Cc: cremona, davidloeffler Merged in:
Authors: Frédéric Chapoton Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: d2d5717 (Commits, GitHub, GitLab) Commit: d2d571749e3164c98ca041006ac28a6dbe4eb955
Dependencies: Stopgaps:

Status badges

Description


Change History (7)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/27107
  • Commit set to d2d571749e3164c98ca041006ac28a6dbe4eb955
  • Status changed from new to needs_review

New commits:

​d2d5717py3: fix massive regression in elliptic curves

comment:2 Changed 3 years ago by chapoton

see #26212. This bad import provokes at least 300 more failing doctests in Python3

comment:3 Changed 3 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review
  • Summary changed from py3: fix massive regression in elliptic curves to py3: fix bad relative import in elliptic curves

The title was a bit too dramatic for a single-line problem :-)

comment:4 Changed 3 years ago by defeo

Don't we have an automated test for this kind of bad imports?

comment:5 Changed 3 years ago by chapoton

Well, sadly, despite all my efforts, no.

comment:6 Changed 3 years ago by cremona

Apologies for my import statement!

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/27107 to d2d571749e3164c98ca041006ac28a6dbe4eb955
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.