Opened 4 years ago

Closed 3 years ago

#27089 closed defect (fixed)

CPLEXBackend.solver_parameter: Handle CPX_PARAMTYPE_LONG

Reported by: mkoeppe Owned by:
Priority: major Milestone: sage-9.0
Component: linear programming Keywords:
Cc: gh-jiawei-wang-ucd, slabbe Merged in:
Authors: David Coudert Reviewers: Sébastien Labbé
Report Upstream: N/A Work issues:
Branch: f8a2eed (Commits, GitHub, GitLab) Commit: f8a2eed01001b84200c1a87c61e4d5c8055f0b73
Dependencies: #28382 Stopgaps:

Status badges

Description

In current versions of CPLEX, we can't set CPX_PARAM_ITLIM because it has the unhandled param type CPX_PARAMTYPE_LONG, which we mistake as a string parameter.

Change History (14)

comment:1 Changed 4 years ago by dcoudert

Right, we should include CPXsetlongparam and CPXgetlongparam, and add relevant tests in method solver_parameter. I don't know however if we need to import type CPXLONG.

comment:2 Changed 4 years ago by dcoudert

  • Authors set to David Coudert
  • Branch set to public/27089_set_long_parameter
  • Commit set to 4c9acee8c21db227e1fb9f142906c1310358ec8d
  • Status changed from new to needs_review

This should do the job.

Some methods were declared twice in cplex_backend.pxd. I also fixed that.


New commits:

4c9aceetrac #27089: set/get long type parameters

comment:3 Changed 3 years ago by dcoudert

ping ;)

comment:4 Changed 3 years ago by embray

  • Milestone changed from sage-8.7 to sage-8.8

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

comment:5 Changed 3 years ago by git

  • Commit changed from 4c9acee8c21db227e1fb9f142906c1310358ec8d to 0e68b7216580d5db194c36b446eb86ed1db81dbe

Branch pushed to git repo; I updated commit sha1. New commits:

9f59a92trac #27089: merged with 8.8.beta5
0e68b72trac #27089: to avoid conflict with 27790

comment:6 Changed 3 years ago by dcoudert

Very minor change to avoid possible conflict with #27790

comment:7 Changed 3 years ago by dcoudert

  • Milestone changed from sage-8.8 to sage-8.9

comment:8 Changed 3 years ago by dcoudert

successfully tested over 8.9.beta7 with cplex 12.8.

comment:9 Changed 3 years ago by git

  • Commit changed from 0e68b7216580d5db194c36b446eb86ed1db81dbe to f8a2eed01001b84200c1a87c61e4d5c8055f0b73

Branch pushed to git repo; I updated commit sha1. New commits:

94026d1trac #28382: fix compilation warnings with cplex backends
a90faectrac #27089: merge with #28382 and fix merge conflicts
f8a2eedtrac #27089: fix compilation warnings using long long instead of long

comment:10 Changed 3 years ago by dcoudert

  • Dependencies set to #28382

I have rebuild this ticket over #28382 and used correct type (long long instead of long). This way we have no compilation warning.

comment:11 Changed 3 years ago by dcoudert

  • Cc slabbe added

comment:12 Changed 3 years ago by dcoudert

  • Milestone changed from sage-8.9 to sage-9.0

comment:13 Changed 3 years ago by slabbe

  • Reviewers set to Sébastien Labbé
  • Status changed from needs_review to positive_review

comment:14 Changed 3 years ago by vbraun

  • Branch changed from public/27089_set_long_parameter to f8a2eed01001b84200c1a87c61e4d5c8055f0b73
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.