Opened 4 years ago
Closed 3 years ago
#27086 closed enhancement (fixed)
Simplicity and simpliciality for CombinatorialPolyhedron
Reported by:  ghkliem  Owned by:  

Priority:  major  Milestone:  sage9.1 
Component:  geometry  Keywords:  Polyhedron, CombinatorialPolyhedron, simple, simplicial, flag 
Cc:  jipilab  Merged in:  
Authors:  Jonathan Kliem  Reviewers:  JeanPhilippe Labbé, Laith Rastanawi 
Report Upstream:  N/A  Work issues:  
Branch:  a19efd6 (Commits, GitHub, GitLab)  Commit:  a19efd6f63db32799d27aa6af2b7b20c08fbf022 
Dependencies:  #28606  Stopgaps: 
Description (last modified by )
We add a function to CombinatorialPolyhedron
that returns the largest k such that the polyhedron is ksimple
/ksimplicial
.
Change History (23)
comment:1 Changed 4 years ago by
 Type changed from PLEASE CHANGE to enhancement
comment:2 Changed 4 years ago by
 Description modified (diff)
 Keywords flag added
 Summary changed from Add simpliciality and simpliness to CombinatorialPolyhedron to More functions for CombinatorialPolyhedron
comment:3 Changed 3 years ago by
 Description modified (diff)
comment:4 Changed 3 years ago by
comment:5 Changed 3 years ago by
 Milestone changed from sage8.7 to sage8.8
Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)
comment:6 Changed 3 years ago by
 Milestone changed from sage8.8 to sagewishlist
comment:7 Changed 3 years ago by
 Description modified (diff)
 Milestone changed from sagewishlist to sage9.0
 Summary changed from More functions for CombinatorialPolyhedron to Simpliness and simpliciality for CombinatorialPolyhedron
comment:8 Changed 3 years ago by
 Dependencies changed from #26887 to #28606
comment:9 Changed 3 years ago by
 Branch set to public/27086
 Commit set to 9f6f17276ae9d74847499a81ce6e23c4104ee6f6
 Status changed from new to needs_review
Last 10 new commits:
37592f9  replace attributes by methods; remove empty folder from source

e865f9d  removed attribute Vinv, as its not being used

84ef31b  added docstrings to the new methods

588afa4  removed method for Vinv

531222d  unbounded(self) > is_bounded(self); _unbounded > _bounded

fb93bed  partly added simpliness

c8c49c5  fixed small mistake in header file

2f0b931  Merge branch 'public/28606' of git://trac.sagemath.org/sage into public/27086

1fc57e3  method simpliciality

9f6f172  method simpliness

comment:10 Changed 3 years ago by
 Commit changed from 9f6f17276ae9d74847499a81ce6e23c4104ee6f6 to 6ec50537b56756a753b8c4b44047af451d6b5d38
Branch pushed to git repo; I updated commit sha1. New commits:
6ec5053  cached the results; opted out when discovering not 2simple/simplicial

comment:11 Changed 3 years ago by
 Commit changed from 6ec50537b56756a753b8c4b44047af451d6b5d38 to 6fd5b2a1403fa50899e53da51885389508a6f6a6
Branch pushed to git repo; I updated commit sha1. New commits:
6fd5b2a  using cached_method as described in #12951

comment:12 Changed 3 years ago by
 Cc jipilab added
 Reviewers set to JeanPhilippe Labbé
 Status changed from needs_review to needs_work
I believe that 'simplicity' is more appropriate than simpliness.
comment:13 Changed 3 years ago by
 Summary changed from Simpliness and simpliciality for CombinatorialPolyhedron to Simplicity and simpliciality for CombinatorialPolyhedron
comment:14 Changed 3 years ago by
 Commit changed from 6fd5b2a1403fa50899e53da51885389508a6f6a6 to 50eeaf6fe09902cca9594546b7c82563a938c81e
Branch pushed to git repo; I updated commit sha1. New commits:
50eeaf6  simplines > simplicity

comment:15 Changed 3 years ago by
 Branch changed from public/27086 to public/27086reb
 Commit changed from 50eeaf6fe09902cca9594546b7c82563a938c81e to e36b271c815930feb5f7a87e1358dd46ea54883f
 Status changed from needs_work to needs_review
Last 10 new commits:
2e3e464  removed empty folder being created in source

7701062  removed attribute Vinv, as its not being used

1b17f6e  added docstrings to the new methods

c51cdd9  removed method for Vinv

dd21f9c  applied changes of 28605 to new code from 28625

4f49eac  undid change to module list

0f3b121  replace attributes by methods; remove attribute Vinv

6550083  unbounded(self) > is_bounded(self); _unbounded > _bounded

8aaaef5  unbounded(self) > is_bounded(self); _unbounded > _bounded

e36b271  added simplicity and simpliciality to CombinatorialPolyhedron

comment:16 Changed 3 years ago by
 Commit changed from e36b271c815930feb5f7a87e1358dd46ea54883f to 8e8ac4e4439dcfd65ce8728e504e7ab0fade5cbd
comment:17 Changed 3 years ago by
 Branch changed from public/27086reb to public/27086reb2
 Commit changed from 8e8ac4e4439dcfd65ce8728e504e7ab0fade5cbd to f131286367b9727f0820c22e55a46ca7be466a43
comment:18 Changed 3 years ago by
 Commit changed from f131286367b9727f0820c22e55a46ca7be466a43 to 2113b470ed94c8dd9c40428be0c3978bcc9b73a7
Branch pushed to git repo; I updated commit sha1. New commits:
2113b47  took into account the changes from #28614

comment:19 Changed 3 years ago by
 Milestone changed from sage9.0 to sage9.1
Ticket retargeted after milestone closed
comment:20 Changed 3 years ago by
 Status changed from needs_review to needs_work
In simplicity
method:
 I suggest to change the definition of
ksimple
. Using the definition you give, one needs to knowP/F
. A polytope `P` is `k`simple, if for every face `F`  of codimension `k` the polytope `P/F` is simple. + A polytope `P` is `k`simple, if every `(d1k)`face + is contained in `k+1` facets of `P` for `1 <= k <= d1`.
 coface instead of face:
if face_iter.n_atom_rep() == d + 1:  # The current face is a simplex. + # The current coface is a simplex. face_iter.ignore_supfaces()
 Since you are dealing with cofaces, maybe you need to do the following change
 cdef FaceIterator face_iter = self._face_iter(True, 2) + cdef FaceIterator coface_iter = self._face_iter(True, 2)
comment:21 Changed 3 years ago by
 Branch changed from public/27086reb2 to public/27086reb3
 Commit changed from 2113b470ed94c8dd9c40428be0c3978bcc9b73a7 to a19efd6f63db32799d27aa6af2b7b20c08fbf022
 Status changed from needs_work to needs_review
comment:22 Changed 3 years ago by
 Reviewers changed from JeanPhilippe Labbé to JeanPhilippe Labbé, Laith Rastanawi
 Status changed from needs_review to positive_review
I believe it is good to go.
comment:23 Changed 3 years ago by
 Branch changed from public/27086reb3 to a19efd6f63db32799d27aa6af2b7b20c08fbf022
 Resolution set to fixed
 Status changed from positive_review to closed
Posting this example, so I won't forget:
An example for simpliness and simpliciality could look like this:
One can replace
6
byn
and this will alter4
ton2
and5
ton1
.(This example is taken from lecture notes from Günter M. Ziegler.)