Opened 3 years ago

Closed 3 years ago

#27084 closed enhancement (fixed)

simplify and clean the list_plot3d file

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: graphics Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 8277406 (Commits, GitHub, GitLab) Commit: 827740663e5e4012d43530c4ca6007690f21616c
Dependencies: Stopgaps:

Status badges

Description

in particular removing ad-hoc keyword "texture", where "color" works

Change History (7)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/27084
  • Commit set to 7519eac6ab20ad2090bc82bddc97e0e13f83aaf4
  • Status changed from new to needs_review

New commits:

​7519eacsimplify and clean-up the file list_plot3d

comment:2 Changed 3 years ago by chapoton

  • Cc tscrim added

green bot, please review

comment:3 Changed 3 years ago by tscrim

Unfortunately, I think we need to deprecate texture at this point: 

-    if texture == "automatic":
-        texture = "lightblue"

Everything else LGTM.

comment:4 Changed 3 years ago by git

  • Commit changed from 7519eac6ab20ad2090bc82bddc97e0e13f83aaf4 to 827740663e5e4012d43530c4ca6007690f21616c

Branch pushed to git repo; I updated commit sha1. New commits:

​8277406trac 27084 adding deprecation for texture at reviewer's request

comment:5 Changed 3 years ago by chapoton

Thanks. Done, and green bot again

comment:6 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

Thank you. LGTM.

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/27084 to 827740663e5e4012d43530c4ca6007690f21616c
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.