Changes between Version 3 and Version 13 of Ticket #27063


Ignore:
Timestamp:
10/18/19 06:40:18 (2 years ago)
Author:
gh-kliem
Comment:

I'm going to put this on needs review, so that people looking at #22420 will notice.

This way I can avoid adding each of the tickets to #22420.

If there is a better way of doing it, please tell me.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #27063

    • Property Status changed from new to needs_review
    • Property Dependencies changed from #26887, #27987 to #28621
    • Property Commit changed from 25407f852d524693571b97e1d26e4fdd264b51fe to c4ccf860ba2906123bd20b4e3a49ad3e94ca7bdb
    • Property Milestone changed from sage-8.8 to sage-pending
  • Ticket #27063 – Description

    v3 v13  
    1 In #26887 we create a new class, that handles the calculations depending only on the combinatorial type much more quickly. The following methods now make use of this:
     1In #26887 we created a new class, that handles the calculations depending only on the combinatorial type more quickly.
    22
    3 - face_lattice
    4 - faces
    5 - f_vector
    6 - vertex_graph
    7 - vertex_digraph
    8 - neighborliness
     3The goal of this ticket is to make use of this class through `Polyhedron_base`.
    94
    10 Maybe adding new methods concerning flag-vector, h-Vector k-simplicial, k-neighborly etc.
     5Add:
     6
     7- #28621: `combinatorial_polyhedron`,
     8- a face iterator,
     9- facet graph
     10
     11Replace:
     12
     13- `f_vector`,
     14- `faces`,
     15- `graph`/`vertex_graph`, `vertex_adjacency_matrix`, `vertex_digraph`
     16- `facet_adjacency_matrix`,
     17- `face_lattice`.
     18
     19Finally, it might make sense to move code to `CombinatorialPolyhedron`. E.g. `is_prism` can be checked there and should only be checked there to avoid code duplication.