Opened 3 years ago

Closed 3 years ago

#27061 closed defect (fixed)

Fix sage.misc.inline_fortran with Numpy 1.16

Reported by: embray Owned by:
Priority: minor Milestone: sage-8.7
Component: misc Keywords:
Cc: Merged in:
Authors: Erik Bray Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: 81cc6bf (Commits, GitHub, GitLab) Commit: 81cc6bf6686103a9f4717ac99913f447f90c1821
Dependencies: Stopgaps:

Status badges

Description (last modified by tmonteil)

Numpy 1.16 introduced a slight backwards incompatibility such that the way we were calling f2py.compile() would no longer work for capturing a log of the f2py output.

It turns out f2py.compile() doesn't do anything very interesting anyways and has many redundancies with what we do here: It's easy to call f2py in a subprocess ourselves with the correct arguments and handle the output.

Change History (7)

comment:1 Changed 3 years ago by embray

  • Status changed from new to needs_review

comment:2 Changed 3 years ago by embray

  • Component changed from PLEASE CHANGE to misc

comment:3 Changed 3 years ago by tmonteil

  • Description modified (diff)

comment:4 Changed 3 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer

comment:5 Changed 3 years ago by jdemeyer

  • Status changed from needs_review to positive_review

Works for me.

comment:6 Changed 3 years ago by embray

FWIW there is an upstream report here: https://github.com/numpy/numpy/issues/12756

It was just closed, but wrongfully IMO.

comment:7 Changed 3 years ago by vbraun

  • Branch changed from u/embray/misc/inline-fortran-update to 81cc6bf6686103a9f4717ac99913f447f90c1821
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.