#27058 closed enhancement (duplicate)
Upgrade to Cython 0.29.2
Reported by:  slelievre  Owned by:  

Priority:  major  Milestone:  sageduplicate/invalid/wontfix 
Component:  packages: standard  Keywords:  upgrade, cython 
Cc:  embray, fbissey, jdemeyer, saraedum, slelievre  Merged in:  
Authors:  Reviewers:  Erik Bray  
Report Upstream:  N/A  Work issues:  
Branch:  u/jdemeyer/upgrade_to_cython_0_29_2 (Commits)  Commit:  40132ee4d7a8a95b641abdbe11787ee833717b1c 
Dependencies:  Stopgaps: 
Description (last modified by )
Change History (13)
comment:1 Changed 14 months ago by
 Description modified (diff)
comment:2 Changed 14 months ago by
 Milestone changed from sage8.6 to sage8.7
comment:3 Changed 14 months ago by
 Branch set to u/jdemeyer/upgrade_to_cython_0_29_2
comment:4 Changed 14 months ago by
 Commit set to 40132ee4d7a8a95b641abdbe11787ee833717b1c
 Reviewers set to François Bissey
Have been using it in sageongentoo since 17/12/2018 and I have done quite a few builds and doctests runs with that. So I think it is OK :)
Positive review from me when you are ready.
New commits:
40132ee  Cython 0.29.2

comment:5 Changed 14 months ago by
 Status changed from new to needs_review
comment:6 Changed 14 months ago by
 Status changed from needs_review to positive_review
comment:7 Changed 14 months ago by
According to the release notes for Numpy 1.16 it requires just Cython>=0.29
. I'm not sure where the "0.29.2" claim is coming from, though it's possible that it fixes some bugs that affect either Numpy or Sage.
comment:8 Changed 14 months ago by
Well, it comes directly from the release announcement: https://mail.python.org/pipermail/numpydiscussion/2019January/079130.html Though in the Numpy 1.16 tag itself it only specifies "Cython>=0.29". I think I'm on numpydiscussion so I'll ask, though at this point it's mostly just for edification.
comment:9 Changed 14 months ago by
Don't worry about it. It's not really important whether it requires Cython0.29 or Cython0.29.2. I was just asking for curiosity.
It's not a bad idea to upgrade Cython anyway, since it is supposed to fix a memory leak.
comment:10 Changed 14 months ago by
I didn't bother asking but I did find the relevant issue in Numpy and it was exactly because of said memory leak.
comment:11 Changed 13 months ago by
 Milestone changed from sage8.7 to sageduplicate/invalid/wontfix
 Status changed from positive_review to needs_review
Fixed by #26969.
comment:12 Changed 13 months ago by
 Resolution set to duplicate
 Status changed from needs_review to closed
Yes, apparently so...
comment:13 Changed 13 months ago by
 Reviewers changed from François Bissey to Erik Bray
If I understand correctly, our convention for duplicate/invalid/wontfix is to have no author and only a reviewer (who reviewed that this is duplicate/invalid/wontfix).
I wonder why numpy insists on Cython 0.29.2, but this upgrade should be trivial.