Opened 3 years ago

Closed 3 years ago

#27055 closed enhancement (fixed)

some simplifications for all

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: refactoring Keywords:
Cc: Merged in:
Authors: Frédéric Chapoton Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: a8db694 (Commits, GitHub, GitLab) Commit: a8db694e230c7f2093098e5693e8c249d4c0a186
Dependencies: Stopgaps:

Status badges

Description

by using all(x for x in y) instead of all([x for x in y])

Found using

git grep -c "[^a-z]all(\[" src/sage/

There remains many more.

Change History (8)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/27055
  • Commit set to 10d6f6d499bf3928efd524e606c110c6b6e37937
  • Status changed from new to needs_review

New commits:

10d6f6dbunch of simplifications from all([...]) to all(...)

comment:2 Changed 3 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to needs_work

Working on small reviewer patch...

comment:3 Changed 3 years ago by jdemeyer

  • Branch changed from u/chapoton/27055 to u/jdemeyer/27055

comment:4 Changed 3 years ago by jdemeyer

  • Commit changed from 10d6f6d499bf3928efd524e606c110c6b6e37937 to a8db694e230c7f2093098e5693e8c249d4c0a186
  • Status changed from needs_work to needs_review

New commits:

a8db694Further minor fixes

comment:5 Changed 3 years ago by chapoton

Thanks for working on that, Jeroen.

Your changes looks good to me. And the patchbot is green.

comment:6 Changed 3 years ago by jdemeyer

  • Status changed from needs_review to positive_review

I assume you meant to positive review to my commit.

comment:7 Changed 3 years ago by embray

  • Milestone changed from sage-8.6 to sage-8.7

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

comment:8 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/27055 to a8db694e230c7f2093098e5693e8c249d4c0a186
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.