Opened 2 years ago

Closed 23 months ago

#27053 closed defect (duplicate)

MR3: Avoid stumbling upon ordering or error class name changes between python2 and python3.

Reported by: galois Owned by:
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: python3 Keywords:
Cc: Merged in:
Authors: Odile Bénassy Reviewers: Erik Bray
Report Upstream: N/A Work issues:
Branch: u/galois/mrs/3/develop (Commits, GitHub, GitLab) Commit: 3dca103294c1b483b669fac96765bf599e6b2a91
Dependencies: Stopgaps:

Status badges

Change History (9)

comment:1 Changed 2 years ago by zerline

  • Component changed from PLEASE CHANGE to python3
  • Description modified (diff)
  • Type changed from PLEASE CHANGE to defect

comment:2 Changed 2 years ago by embray

  • Status changed from needs_review to needs_work

I added some review on the MR. I think this branch highlights some larger changes that are needed with repr-ing of sets and nip that in the bud once and for all (otherwise there will need to be many, many # py2 / # py3 flags for tests that have Set outputs, and even that won't really be sufficient since the order should be treated as arbitrary regardless of Python version).

comment:3 Changed 2 years ago by embray

  • Reviewers set to Erik Bray

comment:4 Changed 2 years ago by galois

  • Commit changed from 5ae412d3cda6bc95a3bd89ffa4f6c9585ff42596 to 3dca103294c1b483b669fac96765bf599e6b2a91

New commits added to merge request. I updated the commit SHA-1. New commits:

3dca103Add gfortran as a prerequisite.

comment:5 Changed 2 years ago by embray

  • Milestone changed from sage-8.6 to sage-8.7

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

comment:6 Changed 2 years ago by jdemeyer

Where did that gfortran commit come from?

comment:7 Changed 2 years ago by embray

https://gitlab.com/sagemath/sage/merge_requests/3#note_131411562 See also my other commentary on there. I don't think this merge request is appropriate as-is since it's just a very limited subset of # py2 and # py3 flags to try to treat an issue (the ordering of Sets when displayed) which needs to be treated more broadly, either by changing how Sets are actually displayed, or by adding a new feature to the doctest framework to allow more flexibility here.

comment:8 Changed 2 years ago by embray

  • Milestone changed from sage-8.7 to sage-8.8

Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)

comment:9 Changed 23 months ago by chapoton

  • Milestone changed from sage-8.8 to sage-duplicate/invalid/wontfix
  • Resolution set to duplicate
  • Status changed from needs_work to closed

All this has now been fixed elsewhere.

Note: See TracTickets for help on using tickets.