Opened 3 years ago

Closed 3 years ago

#27048 closed enhancement (fixed)

py3: one fix in invariant_theory

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: ba2dfb6 (Commits, GitHub, GitLab) Commit: ba2dfb650b0058295d4455be0011bdca20d2de4d
Dependencies: Stopgaps:

Status badges

Description

inside a private method used only in this file

plus a few pep8 modifications

Change History (5)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/27048
  • Commit set to ba2dfb650b0058295d4455be0011bdca20d2de4d
  • Status changed from new to needs_review

New commits:

​ba2dfb6py3 some fixes in invariant_theory and a few pep8 changes

comment:2 Changed 3 years ago by chapoton

  • Cc tscrim added

green bot, please review

comment:3 Changed 3 years ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 3 years ago by embray

In #27014, Jeroen added a _stable_uniq, so if you wanted you could just write this 

from sage.misc.misc import _stable_uniq as uniq
...
    variables = tuple(uniq(p.variables()))
Last edited 3 years ago by embray (previous) (diff)

comment:5 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/27048 to ba2dfb650b0058295d4455be0011bdca20d2de4d
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.