Opened 17 months ago
Last modified 7 weeks ago
#27047 needs_work enhancement
Tropical Frieze Patterns
Reported by:  Bruce  Owned by:  

Priority:  major  Milestone:  sage9.2 
Component:  combinatorics  Keywords:  growth diagram 
Cc:  tscrim, mantepse, aschilling, deinst, kdilks  Merged in:  
Authors:  Reviewers:  
Report Upstream:  N/A  Work issues:  
Branch:  u/kdilks/tropical_frieze_patterns (Commits)  Commit:  b8cc47e6cb8978a33e1e7364820938aaf14665c5 
Dependencies:  #25434  Stopgaps: 
Description
This implements the local rules in #25434 for two row increasing tableaux. These local rules are due to Oliver Pechenik.
Change History (9)
comment:1 Changed 17 months ago by
 Branch set to u/Bruce/tropical_frieze_patterns
comment:2 Changed 17 months ago by
 Commit set to 013c1a6a9b75f41edd405ec12f51b9833b91ffd5
 Status changed from new to needs_review
comment:3 Changed 17 months ago by
 Milestone changed from sage8.6 to sage8.7
Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sagepending or sagewishlist.
comment:4 Changed 14 months ago by
 Milestone changed from sage8.7 to sage8.8
Ticket retargeted after milestone closed (if you don't believe this ticket is appropriate for the Sage 8.8 release please retarget manually)
comment:5 Changed 13 months ago by
 Branch changed from u/Bruce/tropical_frieze_patterns to u/kdilks/tropical_frieze_patterns
comment:6 Changed 11 months ago by
 Milestone changed from sage8.8 to sage8.9
Moving tickets from the Sage 8.8 milestone that have been actively worked on in the last six months to the next release milestone (optimistically).
comment:7 Changed 9 months ago by
 Commit changed from 013c1a6a9b75f41edd405ec12f51b9833b91ffd5 to b8cc47e6cb8978a33e1e7364820938aaf14665c5
 Status changed from needs_review to needs_work
From looking at the code here are some things that should be fixed:
 Missing Authors in the Authors field (required to get bots to run on the tickets)
 Coverage is not 100%: every methods needs to have an EXAMPLE and likely a TESTS block (for example testing that raising errors work appropriately.
 Some pyflakes errors occur: some imports are not needed
 Perhaps be more precise than
'this can't happen'
in theRuntimeErrors
messages.
Further, many methods docstring do not have the usual OUTPUT block so as to know which type of object is returned. Please have a look at http://doc.sagemath.org/html/en/developer/coding_basics.html for a detail of the conventions.
New commits:
92e8713  Merge branch 'u/Bruce/tropical_frieze_patterns' of git://trac.sagemath.org/sage into tropfriez27047

b8cc47e  Fixed module link

comment:8 Changed 5 months ago by
 Milestone changed from sage8.9 to sage9.1
Ticket retargeted after milestone closed
comment:9 Changed 7 weeks ago by
 Milestone changed from sage9.1 to sage9.2
Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.
Last 10 new commits:
Tidy up
Merge branch 'develop' into t/25434/pathtableaux
Dealt with Travis' objection to my __getattr__ hack and most of his other comments.
Made minor changes to catalan.py
Changed directory name
Changed import to new file names
Moved ClonableArray from ABC class to implementation
Initial commit
Finished doctests
Merge branch 'tropical_frieze_patterns' into t/27047/tropical_frieze_patterns