Opened 3 years ago

Closed 3 years ago

#27042 closed enhancement (fixed)

adding method is_sperner for posets

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: combinatorics Keywords:
Cc: jmantysalo Merged in:
Authors: Frédéric Chapoton Reviewers: Jori Mäntysalo
Report Upstream: N/A Work issues:
Branch: a354b60 (Commits, GitHub, GitLab) Commit: a354b6084972adcf708adfcf9773dbda589ca9c2
Dependencies: Stopgaps:

Status badges

Description

naive method to check if some poset is Sperner

Change History (10)

comment:1 Changed 3 years ago by chapoton

  • Branch set to u/chapoton/27042
  • Commit set to 8af154edf4c1710f9ab50ed68a1bf5c4d0b37e88
  • Status changed from new to needs_review

New commits:

​8af154eadding the method "is_sperner" to posets

comment:2 Changed 3 years ago by jmantysalo

  • Reviewers set to Jori Mäntysalo

I can check this.

comment:3 Changed 3 years ago by jmantysalo

  • Status changed from needs_review to needs_work

You should define if the empty poset is Sperner or not (I guess it is). Currently it throws ValueError: max() arg is an empty sequence.

comment:4 Changed 3 years ago by git

  • Commit changed from 8af154edf4c1710f9ab50ed68a1bf5c4d0b37e88 to 006ae998b826db5fe75197342f873c234620ab3f

Branch pushed to git repo; I updated commit sha1. New commits:

​006ae99trac 27042 empty poset special case

comment:5 Changed 3 years ago by chapoton

  • Status changed from needs_work to needs_review

done, thanks

comment:6 Changed 3 years ago by jmantysalo

  • Status changed from needs_review to positive_review

Now it is OK.

comment:7 Changed 3 years ago by git

  • Commit changed from 006ae998b826db5fe75197342f873c234620ab3f to a354b6084972adcf708adfcf9773dbda589ca9c2
  • Status changed from positive_review to needs_review

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

​a354b60typo in SEEALSO

comment:8 Changed 3 years ago by chapoton

  • Status changed from needs_review to positive_review

patchbot found a typo, and I fixed it. Setting back to positive

comment:9 Changed 3 years ago by embray

  • Milestone changed from sage-8.6 to sage-8.7

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

comment:10 Changed 3 years ago by vbraun

  • Branch changed from u/chapoton/27042 to a354b6084972adcf708adfcf9773dbda589ca9c2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.