#27039 closed task (fixed)
Add DESTDIR support for optional packages that use autotools
Reported by: | embray | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | sage-8.7 |
Component: | packages: optional | Keywords: | destdir 4ti2 bliss cbc csdp deformation fricas gp2c igraph latte_int libogg lidia lrslib mpfrcx sirocco tdlib |
Cc: | Merged in: | ||
Authors: | Erik Bray | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | 1747a4c (Commits, GitHub, GitLab) | Commit: | |
Dependencies: | Stopgaps: |
Description (last modified by )
All these packages have standard autotools builds, so their transformation was mostly mechanical and trivial. Only two slight exceptions:
- The
configure
script for deformation is not actually generated by autoconf and does not support all the standard options (e.g.--libdir
). However, the rest of it is straightforward.
- For mpfrcx we also add an
spkg-legacy-uninstall
script.
I've tested all of these and confirmed that they still build properly, and that the files listed in their file manifests look logical, and doctests pass for me on Linux. There should really be no difference for these packages compared to how they were previously built and installed.
Change History (6)
comment:1 Changed 3 years ago by
- Description modified (diff)
- Status changed from new to needs_review
comment:2 follow-up: ↓ 3 Changed 3 years ago by
comment:3 in reply to: ↑ 2 Changed 3 years ago by
Replying to chapoton:
In
tdlib
, you addedsdh_make
where there was nomake
. Is this ok ?Otherwise, positive review
I double-checked on this just to be sure, but it is indeed a standard automake package so it is harmless to add the make call, and it looks more "standard" without it. The fact is, this package is just a collection of headers, so there is nothing to "build" with a make
call and it's possible to just skip straight to make install
. But should that change for any reason at least our bases are covered this way. Good catch though--it wasn't obvious.
comment:4 Changed 3 years ago by
- Reviewers set to Frédéric Chapoton
- Status changed from needs_review to positive_review
ok, thanks
comment:5 Changed 3 years ago by
- Branch changed from u/embray/build/destdir-optional-autotools to 1747a4c591676b9166ca47b1ae6c6a2d721bd52e
- Resolution set to fixed
- Status changed from positive_review to closed
comment:6 Changed 3 years ago by
- Commit 1747a4c591676b9166ca47b1ae6c6a2d721bd52e deleted
Great to see this merged. Thanks!
In
tdlib
, you addedsdh_make
where there was nomake
. Is this ok ?Otherwise, positive review