Opened 3 years ago
Closed 3 years ago
#27038 closed enhancement (fixed)
pyflakes cleanup in schemes
Reported by:  chapoton  Owned by:  

Priority:  major  Milestone:  sage8.7 
Component:  algebraic geometry  Keywords:  
Cc:  tscrim  Merged in:  
Authors:  Frédéric Chapoton  Reviewers:  Travis Scrimshaw 
Report Upstream:  N/A  Work issues:  
Branch:  8acfcec (Commits, GitHub, GitLab)  Commit:  8acfcec74635a10d5fb381c9dcae64eee89e7af8 
Dependencies:  Stopgaps: 
Description
including one bug fixed in base_extend
for affine schemes
Change History (8)
comment:1 Changed 3 years ago by
 Branch set to u/chapoton/27038
 Commit set to f90d9113e918a52629cfc835dd2dd3dd14321db0
 Status changed from new to needs_review
comment:2 Changed 3 years ago by
 Cc tscrim added
green bot ;
src/sage/schemes/hyperelliptic_curves/hyperelliptic_g2_generic.py
is a big mess that I do not want to clean here..
comment:3 Changed 3 years ago by
Can you add a doctest for the bug that you fixed? Also, if len(v):
> if v:
. Other than that LGTM.
comment:4 Changed 3 years ago by
Thanks. The doctest is already added. Let me take care of the rest now.
EDIT: added doctest is in src/sage/schemes/generic/scheme.py
comment:5 Changed 3 years ago by
 Commit changed from f90d9113e918a52629cfc835dd2dd3dd14321db0 to 8acfcec74635a10d5fb381c9dcae64eee89e7af8
Branch pushed to git repo; I updated commit sha1. New commits:
8acfcec  trac 27038 little change

comment:6 Changed 3 years ago by
 Reviewers set to Travis Scrimshaw
 Status changed from needs_review to positive_review
Ah, I see the doctest now. I missed that, sorry. Thank you.
comment:7 Changed 3 years ago by
 Milestone changed from sage8.6 to sage8.7
Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sagepending or sagewishlist.
comment:8 Changed 3 years ago by
 Branch changed from u/chapoton/27038 to 8acfcec74635a10d5fb381c9dcae64eee89e7af8
 Resolution set to fixed
 Status changed from positive_review to closed
New commits:
some pyflakes cleanup in schemes (fix one bug)