Avoid calling vertices() in graph_isom_equivalent_non_edge_labeled_graph()

[Jeroen Demeyer]

New commits:

​70e123b

Avoid calling vertices() in graph_isom_equivalent_non_edge_labeled_graph()

[Travis Scrimshaw]

This breaks stuff in root systems:

sage -t --long src/sage/combinat/root_system/extended_affine_weyl_group.py  # 404 doctests failed
sage -t --long src/sage/combinat/root_system/cartan_type.py  # 6 doctests failed
sage -t --long src/sage/categories/magmas.py  # 3 doctests failed
sage -t --long src/sage/combinat/root_system/fundamental_group.py  # 118 doctests failed
sage -t --long src/doc/en/thematic_tutorials/lie/affine.rst  # 1 doctest failed

It looks like it has to do with computing the orbit of 0 in the Dynkin diagram (think special edge-labeled directed graphs) and the DynkinDiagram.relabel method must take one parameter.

[Jeroen Demeyer]

The problem is that DynkinDiagram_class decided to provide a relabel() method with a different interface than the base graph class.

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​a88dc2c	Make relabel() of DynkinDiagram more compatible with GenericGraph
​5ec5eb0	Avoid calling vertices() in graph_isom_equivalent_non_edge_labeled_graph()

[Jeroen Demeyer]

Green patchbot!

[Travis Scrimshaw]

LGTM (assuming any further changes on #27033 do not affect this ticket).

[git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

​74cebb3

Avoid calling vertices() in graph_isom_equivalent_non_edge_labeled_graph()

[Jeroen Demeyer]

I removed the commit #27033 from this ticket because that will likely change. But the dependency is still here, so it won't be merged before #27033.

[Jeroen Demeyer]

Let's wait until #27033 has positive review.

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​f360ac0	Make relabel() of DynkinDiagram more compatible with GenericGraph
​864f7de	Avoid calling vertices() in graph_isom_equivalent_non_edge_labeled_graph()

[Travis Scrimshaw]

LGTM. Thanks.

[Erik Bray]

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

[git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

​6cfcbb0

Avoid calling vertices() in graph_isom_equivalent_non_edge_labeled_graph()

[Jeroen Demeyer]

New attempt. The code is now closer to what it used to be: whenever the set of vertices (in any order) equals range(G.order()), I don't relabel. I also added a comment why:

    # Do not relabel if the set of vertices is equal to the set
    # range(n). This helps to ensure that *equal* graphs on range(n)
    # yield *equal* (not just isomorphic) canonical labelings. This
    # is just a convenience, there is no mathematical meaning.

[Travis Scrimshaw]

Works for me.