Opened 3 years ago

Closed 3 years ago

#27020 closed enhancement (fixed)

OpenBLAS 0.3.5

Reported by: jdemeyer Owned by:
Priority: major Milestone: sage-8.7
Component: packages: standard Keywords:
Cc: gh-timokau, saraedum, arojas, fbissey Merged in:
Authors: Jeroen Demeyer Reviewers: Thierry Monteil, Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: 01567a7 (Commits, GitHub, GitLab) Commit: 01567a71989fd49ba1ab548fe2496a99be0b7d97
Dependencies: Stopgaps:

Status badges

Change History (17)

comment:1 Changed 3 years ago by jdemeyer

  • Cc gh-timokau added

comment:2 Changed 3 years ago by jdemeyer

  • Status changed from new to needs_review

comment:3 Changed 3 years ago by tmonteil

  • Branch set to u/tmonteil/openblas_0_3_5

comment:4 Changed 3 years ago by git

  • Commit set to 749867db341aa6279a2da26ee5676d1426279fab

Branch pushed to git repo; I updated commit sha1. New commits:

749867d#27020 : one patch has been merged

comment:5 Changed 3 years ago by tmonteil

  • Description modified (diff)

Apparently, you forgot the branch ! Note that clicking on the github link leads to a file named OpenBLAS-0.3.5.tar.gz, which is consistent with the checksums.ini file.

comment:6 Changed 3 years ago by tmonteil

On my machine, tests pass successfully.

comment:7 Changed 3 years ago by jdemeyer

  • Branch changed from u/tmonteil/openblas_0_3_5 to u/jdemeyer/openblas_0_3_5

comment:8 follow-up: Changed 3 years ago by tscrim

  • Commit changed from 749867db341aa6279a2da26ee5676d1426279fab to 01567a71989fd49ba1ab548fe2496a99be0b7d97
  • Reviewers set to Thierry Monteil, Travis Scrimshaw
  • Status changed from needs_review to positive_review

May the buildbots be with you.

Thierry, I added you as a reviewer based on comment:5.


New commits:

01567a7Upgrade to OpenBLAS 0.3.5

comment:9 in reply to: ↑ 8 ; follow-up: Changed 3 years ago by tmonteil

Replying to tscrim:

May the buildbots be with you.

Thierry, I added you as a reviewer based on comment:5.

Great.

Jeroen, why did you rename OpenBLAS to openblas while the former allows to download directly from upstream without having to rename ?

comment:10 in reply to: ↑ 9 Changed 3 years ago by jdemeyer

Replying to tmonteil:

Jeroen, why did you rename OpenBLAS to openblas while the former allows to download directly from upstream without having to rename ?

As far as I know, the only "releases" that OpenBLAS provides are packed github tarballs which are named like v0.3.5.tar.gz

Version 0, edited 3 years ago by jdemeyer (next)

comment:11 Changed 3 years ago by gh-timokau

The link points to a file named v0.3.5.tar.gz, but at least for me (and apparently others) the browser automatically detects the filename as OpenBLAS... and saves it under that name. Not sure what is going on there.

comment:12 Changed 3 years ago by jdemeyer

  • Description modified (diff)

comment:13 Changed 3 years ago by jdemeyer

I still prefer download locations that do not require special browser tricks.

comment:14 follow-up: Changed 3 years ago by jdemeyer

Anyway, I'll remember for the next time to use OpenBLAS but for this ticket, it doesn't really matter.

comment:15 in reply to: ↑ 14 Changed 3 years ago by gh-timokau

Replying to jdemeyer:

it doesn't really matter.

Right.

comment:16 Changed 3 years ago by embray

  • Milestone changed from sage-8.6 to sage-8.7

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

comment:17 Changed 3 years ago by vbraun

  • Branch changed from u/jdemeyer/openblas_0_3_5 to 01567a71989fd49ba1ab548fe2496a99be0b7d97
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.