Opened 5 months ago

Closed 4 months ago

#27013 closed enhancement (fixed)

py3: some care for Hadamard matrices

Reported by: chapoton Owned by:
Priority: major Milestone: sage-8.7
Component: python3 Keywords:
Cc: tscrim Merged in:
Authors: Frédéric Chapoton Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: b806b2e (Commits) Commit: b806b2e9b773121a9e4479bd10da7f5a45b717e1
Dependencies: Stopgaps:

Description


Change History (8)

comment:1 Changed 5 months ago by chapoton

  • Branch set to u/chapoton/27013
  • Commit set to 3c187780ac07c55b7efeb15de264c29f8af0de9d
  • Status changed from new to needs_review

New commits:

3c18778py3: some care for Hadamard matrices

comment:2 Changed 5 months ago by chapoton

  • Cc tscrim added

green bot, please review

comment:3 Changed 5 months ago by tscrim

  • Reviewers set to Travis Scrimshaw
  • Status changed from needs_review to positive_review

LGTM.

comment:4 Changed 5 months ago by embray

  • Milestone changed from sage-8.6 to sage-8.7
  • Status changed from positive_review to needs_work

This could avoid a superfluous list(...) by just using a list comprehension instead.

comment:5 Changed 5 months ago by git

  • Commit changed from 3c187780ac07c55b7efeb15de264c29f8af0de9d to b806b2e9b773121a9e4479bd10da7f5a45b717e1

Branch pushed to git repo; I updated commit sha1. New commits:

b806b2ereviewer nitpick

comment:6 Changed 5 months ago by chapoton

  • Status changed from needs_work to positive_review

comment:7 Changed 5 months ago by embray

Thank you, that looks much better IMO.

comment:8 Changed 4 months ago by vbraun

  • Branch changed from u/chapoton/27013 to b806b2e9b773121a9e4479bd10da7f5a45b717e1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.